Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color theming bugs #138

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix color theming bugs #138

merged 2 commits into from
Sep 16, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Sep 16, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves:

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Update dependencies
  • Fix small issues with the color theming tokens

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Fix color theming issues in checkbox components by updating the theming tokens to ensure consistent appearance across various states, including focus, hover, and error.

Bug Fixes:

  • Correct color theming tokens for checkbox components to ensure consistent theming across different states such as focus, hover, and error.

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@jordanjones243 jordanjones243 self-assigned this Sep 16, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner September 16, 2024 19:50
Copy link

sourcery-ai bot commented Sep 16, 2024

Reviewer's Guide by Sourcery

This pull request addresses color theming bugs in the checkbox component. The changes focus on updating the CSS variables for different states of the checkbox, including focus, hover, checked, and error states. The implementation also improves the specificity of selectors to ensure proper styling application.

File-Level Changes

Change Details Files
Update focus state styling
  • Change border and outline color variables for focus state
  • Use --ds-color-border-ui-focus-default instead of --ds-color-border-ui-active-default
src/color.scss
Improve hover state styling for checked checkboxes
  • Add .label--cbx class to hover selectors for checked state
  • Increase specificity of hover selectors
src/color.scss
Refactor disabled state styling
  • Add .label--cbx class to hover selectors for disabled state
  • Increase specificity of hover selectors for disabled checkboxes
src/color.scss
Update error state styling
  • Add .label--cbx class to hover selectors for error state
  • Increase specificity of hover selectors for error state
  • Update color variables for error state hover
src/color.scss

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@jordanjones243 jordanjones243 merged commit 15a433e into beta Sep 16, 2024
4 checks passed
@jordanjones243 jordanjones243 deleted the jjones/colorBetaFixes branch September 16, 2024 19:51
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.1.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants