Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: update dependencies #143

Merged
merged 1 commit into from
Sep 24, 2024
Merged

perf: update dependencies #143

merged 1 commit into from
Sep 24, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Sep 23, 2024

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Enhance the styling of the checkbox component by updating the CSS variable for the checkmark color to use a more specific primary disabled default color.

Enhancements:

  • Update the CSS variable for the checkbox checkmark color to use a more specific primary disabled default color.

BREAKING CHANGE: trigger major releaes for theme support #128
@jason-capsule42 jason-capsule42 requested a review from a team as a code owner September 23, 2024 22:45
@jason-capsule42 jason-capsule42 self-assigned this Sep 23, 2024
Copy link

sourcery-ai bot commented Sep 23, 2024

Reviewer's Guide by Sourcery

This pull request updates the color variable used for the checkmark in disabled and checked checkboxes. The change is made to improve the visual consistency and accessibility of the checkbox component.

File-Level Changes

Change Details Files
Update color variable for disabled and checked checkbox checkmark
  • Replace '--ds-color-icon-ui-disabled-default' with '--ds-color-icon-ui-primary-disabled-default'
src/color.scss

Sequence Diagram

No sequence diagram generated.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@jason-capsule42 jason-capsule42 linked an issue Sep 23, 2024 that may be closed by this pull request
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR title 'perf: update dependencies' doesn't match the actual change. Please update the title to accurately reflect the CSS color variable modification.
  • Consider adding a brief explanation in the PR description about why this specific color variable change was made. This context helps reviewers and future maintainers understand the reasoning behind the modification.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@jordanjones243 jordanjones243 merged commit 46fd4fb into beta Sep 24, 2024
4 checks passed
@jordanjones243 jordanjones243 deleted the jbaker/updateDeps branch September 24, 2024 17:43
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-checkbox: Theming support
3 participants