Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(tests): update time comparison to tests to work in any time zone. #216

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Apr 24, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Summary:

This change updates the date comparison in the tests to work in any time zone. This resolves the issue of tests failing in the cloud found here: https://github.com/AlaskaAirlines/auro-datepicker/actions/runs/8808360146/job/24207884952

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jason-capsule42 jason-capsule42 self-assigned this Apr 24, 2024
@jason-capsule42 jason-capsule42 marked this pull request as ready for review April 24, 2024 15:16
@jason-capsule42 jason-capsule42 requested a review from a team as a code owner April 24, 2024 15:16
Copy link

Surge demo deployment succeeded! 🚀🚀🚀

Auro Web Component Generator

@jason-capsule42 jason-capsule42 merged commit 186f16d into main Apr 24, 2024
7 checks passed
@jason-capsule42 jason-capsule42 deleted the jbaker/fixTimezoneValidation branch April 24, 2024 17:10
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile auro-calendar: Setting "value" param on datepicker prevents preceeding months from being visible
3 participants