-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change method for importing enUS locale #274
Conversation
Reviewer's Guide by SourceryThis PR modifies the method for importing the enUS locale across multiple files in the project. The changes appear to be focused on updating import statements or locale-related code, though the specific implementation details are not visible in the provided diff. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide context about what problem this change is solving and why the current import method needs to be changed.
- Since this change affects multiple files including minified versions, please describe how this has been tested to ensure the functionality remains intact.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Surge demo deployment failed! 😭 |
🎉 This PR is included in version 3.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Bug Fixes: