Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toggleDialog is not being included in dist directory #6

Closed
jordanjones243 opened this issue Feb 2, 2024 · 0 comments · Fixed by #7
Closed

toggleDialog is not being included in dist directory #6

jordanjones243 opened this issue Feb 2, 2024 · 0 comments · Fixed by #7
Assignees
@jordanjones243
Labels
auro-dialog Type: Bug Bug or Bug fixes

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Feb 2, 2024 •
edited
Loading

Please verify the version of auro-drawer you have installed

1.0.2

Please describe the bug

  1. Locally pull down the auro-dialog repo
  2. Run a clean install and build
  3. Open up dist directory
  4. See error

Reproducing the error

This issue cannot be reproduced on the Auro docsite

Expected behavior

dist directory includes toggleDialog.js, as it is needed for the demo examples

What browsers are you seeing the problem on?

Chrome

Exit criteria

toggleDialog.js is added to the dist directory upon build.
@jordanjones243 jordanjones243 added not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Feb 2, 2024
@jordanjones243 jordanjones243 added auro-dialog and removed not-reviewed Issue has not been reviewed by Auro team members labels Feb 2, 2024
jordanjones243 added a commit that referenced this issue Feb 2, 2024
@jordanjones243
fix(dist): add apiExample js to dist folder #6
1c2dc01
@jordanjones243 jordanjones243 linked a pull request Feb 2, 2024 that will close this issue
Add apiExample js file to dist #7
Merged
6 tasks
jason-capsule42 pushed a commit that referenced this issue Feb 5, 2024
@jordanjones243 @jason-capsule42
fix(dist): add apiExample js to dist folder #6
565af94
jordanjones243 pushed a commit that referenced this issue Feb 5, 2024
@semantic-release-bot
chore(release): 1.0.3 [skip ci]
725ef50 
## [1.0.3](v1.0.2...v1.0.3) (2024-02-05)

### Bug Fixes

* **dist:** add apiExample js to dist folder [#6](#6) ([565af94](565af94))
* **label:** update labels to auro-dialog ([7ab983f](7ab983f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-dialog Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add apiExample js file to dist AlaskaAirlines/auro-dialog
4 participants
@blackfalcon @jordanjones243 @Patrick-Daly-AA @pgm369