Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move theming support from Beta to Main #19

Merged
merged 13 commits into from
Oct 4, 2024
Merged

Move theming support from Beta to Main #19

merged 13 commits into from
Oct 4, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Aug 14, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #13

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Move theming support from Beta to Main by introducing design tokens for component customization, refactor to use versioned Auro components, and update documentation with theming instructions.

New Features:

  • Introduce theming support for components, allowing customization through design tokens.

Enhancements:

  • Refactor the component to use versioned Auro components for buttons and icons, improving maintainability and consistency.
  • Update the component to use static HTML imports for better performance and modularity.

Documentation:

  • Add documentation on how to restyle components using design tokens, providing examples for customization.

jordanjones243 and others added 6 commits July 3, 2024 17:15
# [1.1.0-beta.1](v1.0.9...v1.1.0-beta.1) (2024-07-04)

### Features

* refactor color token structure with tier 3 tokens [#13](#13) ([179e468](179e468))
* **version:** use custom versioned auro components ([8de7e7c](8de7e7c))
# [1.1.0-beta.2](v1.1.0-beta.1...v1.1.0-beta.2) (2024-07-08)

### Performance Improvements

* **button:** use new version of flat variant button ([17ce223](17ce223))
@jordanjones243 jordanjones243 self-assigned this Aug 14, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner August 14, 2024 18:13
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jordanjones243
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

sourcery-ai bot commented Aug 14, 2024

Reviewer's Guide by Sourcery

This pull request moves theming support from Beta to Main, introducing significant changes to the dialog component's implementation. The changes focus on improving theming capabilities, updating dependencies, and refactoring the code structure. Key modifications include the introduction of new CSS variables for theming, updates to component versioning, and changes to the dialog's visual appearance and behavior.

File-Level Changes

Files Changes
src/componentBase.js Updated import statements and dependencies, including the introduction of new Auro Design System components
src/componentBase.js
src/buttonVersion.js
src/iconVersion.js
Implemented versioning for Auro components using AuroDependencyVersioning
src/componentBase.js Replaced custom close button implementation with Auro Button and Icon components
src/componentBase.js
src/color.scss
src/tokens.scss
Added new CSS files for colors and tokens
src/style.scss Refactored SCSS styles to use new theming variables and improve maintainability
demo/api.md
docs/partials/api.md
Added theme support documentation and examples
CHANGELOG.md Updated CHANGELOG.md with new features and improvements
README.md Updated README.md with new version information
demo/api.html
demo/index.html
Removed unnecessary script imports from demo files
eslint.config.mjs Added new ESLint configuration file

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@jordanjones243 jordanjones243 linked an issue Aug 14, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Hard-coded version number found for auro-button. (link)
  • Hard-coded version number found for auro-icon. (link)
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🔴 Security: 2 blocking issues
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

src/componentBase.js Show resolved Hide resolved
src/buttonVersion.js Outdated Show resolved Hide resolved
src/iconVersion.js Outdated Show resolved Hide resolved
jordanjones243 and others added 6 commits October 3, 2024 15:01
BREAKING CHANGE: trigger major release for color theme support #13
# [2.0.0-beta.1](v1.1.0-beta.2...v2.0.0-beta.1) (2024-10-03)

### Bug Fixes

* resolve minor color theming issues ([04aed67](04aed67))

### Features

* add tag name as attribute when custom registered ([e749245](e749245))

### Performance Improvements

* refactor custom component registration config ([5c1afc8](5c1afc8))
* update dependencies ([eea1e4f](eea1e4f))

### BREAKING CHANGES

* trigger major release for color theme support #13
@jordanjones243
Copy link
Contributor Author

🎉 This PR is included in version 2.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jason-capsule42 jason-capsule42 merged commit dce51eb into main Oct 4, 2024
8 of 9 checks passed
@jordanjones243
Copy link
Contributor Author

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jordanjones243 jordanjones243 added the released Completed work has been released label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support
4 participants