fix: close any open dropdown or related components with overlay clicks

[sun-mota]

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #40

Summary:

Clicking overlay will not close the dialog when there is an open dropdown

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

• New capability
• Revision of an existing capability
• Infrastructure change (automation, etc.)
• Other (please elaborate)

Checklist:

• My update follows the CONTRIBUTING guidelines of this project
• I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses issue #40 by modifying the overlay click handling in the ComponentBase class to ensure that dialogs are not closed if any dropdown components are open. Additionally, the auro-menu script is added to the demo page to support testing of the changes.

Sequence diagram for overlay click handling with dropdowns

sequenceDiagram
    actor User
    participant Overlay
    participant ComponentBase
    participant Dropdowns

    User->>Overlay: clicks
    activate Overlay
    Overlay->>ComponentBase: handleOverlayClick()
    activate ComponentBase
    alt open && !modal
        ComponentBase->>ComponentBase: Query for dropdowns
        ComponentBase->>Dropdowns: Check isPopoverVisible
        activate Dropdowns
        Dropdowns-->>ComponentBase: Dropdown states
        deactivate Dropdowns
        alt no dropdowns open
            ComponentBase->>ComponentBase: handleCloseButtonClick()
        end
    end
    deactivate ComponentBase
    deactivate Overlay

Loading

Class diagram showing ComponentBase changes

classDiagram
    class ComponentBase {
        +boolean open
        +boolean modal
        +handleOverlayClick()
        +handleCloseButtonClick()
    }
    note for ComponentBase "Modified handleOverlayClick to check
for open dropdowns before closing"

Loading

File-Level Changes

Change	Details	Files
Modify overlay click handling to account for open dropdowns	Check for open dropdown components before closing the dialog Query for dropdown components and check their visibility Prevent dialog closure if any dropdown is open	src/componentBase.js
Add auro-menu script to demo page	Include auro-menu script in the demo page for testing purposes	demo/api.html

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

Surge demo deployment failed! 😭

[sourcery-ai]

Hey @sun-mota - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[jordanjones243]

🎉 This PR is included in version 2.3.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀