Skip to content

Commit

Permalink
perf: update general feedback for update node 18
Browse files Browse the repository at this point in the history
Change to be committed:
modified: .stylelintrc
modified: package-lock.json
modified: package.json
modified: .github/ISSUE_TEMPLATE/bug_report.yml
modified: .husky/pre-commit
modified: src/style.scss
deleted: scripts/pre-commit.js
new file: scripts/pre-commit.mjs
  • Loading branch information
irma-kurnia-phtn authored and blackfalcon committed May 24, 2023
1 parent 6f13cd2 commit af2692e
Show file tree
Hide file tree
Showing 7 changed files with 461 additions and 1,921 deletions.
8 changes: 6 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,12 @@ body:
id: details
attributes:
label: Please describe the bug
description: List out the steps to reproduce the behavior
placeholder: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error
description: List out the steps to reproduce the behavior and include screenshots
placeholder: |
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
- type: dropdown
id: repro
attributes:
Expand Down
2 changes: 1 addition & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

./node_modules/.bin/npm-run-all linters test
./node_modules/.bin/npm-run-all preCommit test linters postinstall
117 changes: 112 additions & 5 deletions .stylelintrc
Original file line number Diff line number Diff line change
@@ -1,9 +1,116 @@
{
"extends": "stylelint-config-recommended",
"extends": [
"stylelint-config-recommended",
"stylelint-config-idiomatic-order",
"stylelint-config-standard-scss"
],
"plugins": [
"stylelint-scss"
],
"rules": {
"no-duplicate-selectors": null,
"font-family-no-duplicate-names": null,
"no-descending-specificity": null,
"selector-type-no-unknown": null
"alpha-value-notation": "number",
"at-rule-empty-line-before": [
"always",
{
"except": [
"after-same-name",
"blockless-after-same-name-blockless",
"first-nested"
],
"ignore": [
"after-comment",
"blockless-after-blockless"
]
}
],
"at-rule-no-unknown": null,
"color-function-notation": "modern",
"color-named": "never",
"declaration-block-no-duplicate-custom-properties": true,
"declaration-block-no-duplicate-properties": true,
"declaration-block-no-redundant-longhand-properties": true,
"declaration-no-important": true,
"font-family-name-quotes": "always-where-recommended",
"font-weight-notation": "numeric",
"function-url-no-scheme-relative": true,
"function-url-quotes": "always",
"hue-degree-notation": "angle",
"max-nesting-depth": 2,
"named-grid-areas-no-invalid": true,
"no-empty-source": null,
"no-unknown-animations": true,
"no-invalid-position-at-import-rule": null,
"scss/at-else-closing-brace-newline-after": "always-last-in-chain",
"scss/at-else-closing-brace-space-after": "always-intermediate",
"scss/at-else-empty-line-before": "never",
"scss/at-else-if-parentheses-space-before": "always",
"scss/at-function-parentheses-space-before": "never",
"scss/at-if-closing-brace-newline-after": "always-last-in-chain",
"scss/at-if-closing-brace-space-after": "always-intermediate",
"scss/at-if-no-null": true,
"scss/at-import-partial-extension": null,
"scss/at-mixin-parentheses-space-before": "never",
"scss/at-rule-conditional-no-parentheses": true,
"scss/at-rule-no-unknown": true,
"scss/comment-no-empty": true,
"scss/declaration-nested-properties-no-divided-groups": true,
"scss/dollar-variable-colon-newline-after": "always-multi-line",
"scss/dollar-variable-colon-space-after": "always-single-line",
"scss/dollar-variable-colon-space-before": "never",
"scss/dollar-variable-empty-line-before": [
"always",
{
"except": [
"first-nested",
"after-dollar-variable"
],
"ignore": [
"after-comment",
"inside-single-line-block"
]
}
],
"scss/dollar-variable-first-in-block": [
true,
{
"ignore": [
"comments",
"imports"
]
}
],
"scss/dollar-variable-no-missing-interpolation": true,
"scss/double-slash-comment-whitespace-inside": "always",
"scss/map-keys-quotes": "always",
"scss/no-duplicate-dollar-variables": true,
"scss/no-duplicate-mixins": true,
"scss/no-global-function-names": true,
"scss/operator-no-newline-after": true,
"scss/operator-no-newline-before": true,
"scss/operator-no-unspaced": true,
"scss/selector-nest-combinators": "always",
"scss/selector-no-redundant-nesting-selector": true,
"selector-attribute-quotes": "always",
"selector-class-pattern": "^[a-z][a-zA-Z0-9]+$",
"selector-id-pattern": "^[a-z][a-zA-Z0-9]+$",
"selector-max-attribute": 1,
"selector-max-class": 1,
"selector-max-combinators": 1,
"selector-max-compound-selectors": 2,
"selector-max-id": 1,
"selector-max-pseudo-class": 2,
"selector-max-type": 1,
"selector-max-universal": 1,
"selector-no-qualifying-type": true,
"selector-pseudo-element-colon-notation": "single",
"selector-type-no-unknown": [
true,
{
"ignore": [
"custom-elements"
]
}
],
"shorthand-property-no-redundant-values": true
}
}
Loading

0 comments on commit af2692e

Please sign in to comment.