Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use library utilities and scripts #235

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Aug 13, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Update dependencies
  • Add function to add attribute to the component when it uses a custom registered name
  • Remove local scripts and point to library scripts

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Update auro-dropdown component to use library utilities and scripts, introduce theme support, refactor color token structure, and remove OnDark API references.

New Features:

  • Add function to handle component tag renaming dynamically.
  • Introduce theme support for auro-dropdown component with new SCSS tokens.

Enhancements:

  • Refactor color token structure to use tier 3 tokens.
  • Replace hard-coded size values with design tokens.
  • Update to use the beta version of auro-icon with theme support.

Build:

  • Update dependencies and remove local scripts in favor of library scripts.

Documentation:

  • Add documentation for theme support and how to restyle the component using SCSS tokens.

Chores:

  • Remove all references to the OnDark API and related styles.
  • Update tsconfig.json to include ES2022 target and node module resolution.
  • Add eslint.config.mjs for ESLint configuration.

@jordanjones243 jordanjones243 self-assigned this Aug 13, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner August 13, 2024 03:00
@CLAassistant
Copy link

CLAassistant commented Aug 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

sourcery-ai bot commented Aug 13, 2024

Reviewer's Guide by Sourcery

This pull request updates the auro-dropdown component to use library utilities and scripts, removes local scripts, and makes significant changes to the component's styling and functionality. The main changes include:

  1. Updating dependencies and removing local scripts in favor of library scripts.
  2. Refactoring the color token structure with tier 3 tokens.
  3. Removing OnDark style support, which is a breaking change.
  4. Updating to use a beta version of auro-icon with theme support.
  5. Replacing hard-coded size values with tokens.
  6. Adding theme support with customizable CSS variables.
  7. Updating the build and development environment configuration.

The changes aim to improve the component's maintainability, consistency with the design system, and flexibility for theming.

File-Level Changes

Files Changes
src/style.scss
src/auro-dropdown.js
Removed OnDark style support, which is a breaking change
src/style.scss
src/color.scss
src/tokens.scss
Refactored color token structure with tier 3 tokens
src/auro-dropdown.js Updated to use beta version of auro-icon with theme support
src/style.scss Replaced hard-coded size values with tokens
src/tokens.scss
demo/api.md
Added theme support with customizable CSS variables
tsconfig.json
eslint.config.mjs
Updated build and development environment configuration
README.md
demo/api.html
demo/index.html
Removed local scripts and updated dependencies
README.md
CHANGELOG.md
demo/api.md
docs/partials/api.md
Updated documentation to reflect changes in component usage and API

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@jordanjones243 jordanjones243 changed the base branch from main to beta August 13, 2024 03:00
@jordanjones243 jordanjones243 merged commit 3ae5a3f into beta Aug 13, 2024
5 of 6 checks passed
@jordanjones243 jordanjones243 deleted the jjones/addNameAsAttr branch August 13, 2024 03:03
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants