Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update color tokens for theming support #70

Closed
2 tasks
jordanjones243 opened this issue Jul 10, 2024 · 1 comment · Fixed by #71 or #72
Closed
2 tasks

Update color tokens for theming support #70

jordanjones243 opened this issue Jul 10, 2024 · 1 comment · Fixed by #71 or #72
Assignees
@jordanjones243
Labels
auro-flightline

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Jul 10, 2024 •
edited
Loading

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243 jordanjones243 added Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team members auro-flightline labels Jul 10, 2024
@jordanjones243 jordanjones243 self-assigned this Jul 10, 2024
@jordanjones243 jordanjones243 changed the title Update tokens for theming support Update color tokens for theming support Jul 10, 2024
jordanjones243 added a commit that referenced this issue Jul 11, 2024
@jordanjones243
feat: implement tier 3 color tokens for theming support #70
5b26a33
@jordanjones243 jordanjones243 mentioned this issue Jul 11, 2024
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Jul 11, 2024 that will close this issue
Implement theming support for color tokens #71
Merged
6 tasks
@jason-capsule42 jason-capsule42 removed the not-reviewed Issue has not been reviewed by Auro team members label Jul 15, 2024
jason-capsule42 pushed a commit that referenced this issue Jul 28, 2024
@jordanjones243 @jason-capsule42
feat: implement tier 3 color tokens for theming support #70
ebef9da
blackfalcon pushed a commit that referenced this issue Jul 28, 2024
@semantic-release-bot
chore(release): 2.2.0-beta.1 [skip ci]
bbb4a35 
# [2.2.0-beta.1](v2.1.4...v2.2.0-beta.1) (2024-07-28)

### Features

* implement tier 3 color tokens for theming support [#70](#70) ([ebef9da](ebef9da))
@jordanjones243 jordanjones243 mentioned this issue Aug 14, 2024
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Aug 14, 2024 that will close this issue
Move theming support from Beta to Main #72
Merged
6 tasks
@jordanjones243
Copy link
Contributor Author

Blocked by auro-badge color theming support release.

jordanjones243 added a commit that referenced this issue Oct 2, 2024
@jordanjones243
perf: update dependencies
7e55eae 
BREAKING CHANGE: trigger major release for color theme support #70
jordanjones243 added a commit that referenced this issue Oct 2, 2024
@jordanjones243
perf: update dependencies
21a5e04 
BREAKING CHANGE: trigger major release for color theme support #70
blackfalcon pushed a commit that referenced this issue Oct 2, 2024
@semantic-release-bot
chore(release): 3.0.0-beta.1 [skip ci]
d22aacb 
# [3.0.0-beta.1](v2.2.0-beta.1...v3.0.0-beta.1) (2024-10-02)

### Features

* add tag name as attribute when custom registered ([4b3c3ec](4b3c3ec))

### Performance Improvements

* **label:** remove github label colors ([8b2bf2c](8b2bf2c))
* refactor custom component registration config ([35368c7](35368c7))
* update dependencies ([21a5e04](21a5e04))

### BREAKING CHANGES

* trigger major release for color theme support #70
jason-capsule42 pushed a commit that referenced this issue Oct 2, 2024
@jordanjones243 @jason-capsule42
feat: implement tier 3 color tokens for theming support #70
4f25758
jason-capsule42 pushed a commit that referenced this issue Oct 2, 2024
@semantic-release-bot @jason-capsule42
chore(release): 2.2.0-beta.1 [skip ci]
f1bb4ce 
# [2.2.0-beta.1](v2.1.4...v2.2.0-beta.1) (2024-07-28)

### Features

* implement tier 3 color tokens for theming support [#70](#70) ([ebef9da](ebef9da))
jason-capsule42 pushed a commit that referenced this issue Oct 2, 2024
@jordanjones243 @jason-capsule42
perf: update dependencies
7bbb894 
BREAKING CHANGE: trigger major release for color theme support #70
jason-capsule42 pushed a commit that referenced this issue Oct 2, 2024
@semantic-release-bot @jason-capsule42
chore(release): 3.0.0-beta.1 [skip ci]
0befa16 
# [3.0.0-beta.1](v2.2.0-beta.1...v3.0.0-beta.1) (2024-10-02)

### Features

* add tag name as attribute when custom registered ([4b3c3ec](4b3c3ec))

### Performance Improvements

* **label:** remove github label colors ([8b2bf2c](8b2bf2c))
* refactor custom component registration config ([35368c7](35368c7))
* update dependencies ([21a5e04](21a5e04))

### BREAKING CHANGES

* trigger major release for color theme support #70
blackfalcon pushed a commit that referenced this issue Oct 2, 2024
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
228c799 
# [3.0.0](v2.1.4...v3.0.0) (2024-10-02)

### Features

* add tag name as attribute when custom registered ([0b8a9e7](0b8a9e7))
* implement tier 3 color tokens for theming support [#70](#70) ([4f25758](4f25758))

### Performance Improvements

* **label:** remove github label colors ([d34ae75](d34ae75))
* refactor custom component registration config ([27e3f74](27e3f74))
* update dependencies ([7bbb894](7bbb894))

### BREAKING CHANGES

* trigger major release for color theme support #70
@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-flightline
Projects
None yet
Milestone
No milestone
3 participants
@jason-capsule42 @jordanjones243 @Patrick-Daly-AA