test: fix failing test on input's clear racing condition

AlaskaAirlines · Nov 15, 2024 · 11ac6c1 · 11ac6c1
1 parent dbd89a6
commit 11ac6c1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/components/input/src/base-input.js b/components/input/src/base-input.js
@@ -614,7 +614,7 @@ export default class BaseInput extends LitElement {
    */
   handleClickClear() {
     this.inputElement.value = "";
-    this.value = undefined;
+    this.value = "";
     this.labelElement.classList.remove('inputElement-label--sticky');
     this.focus();
     this.validation.validate(this);

diff --git a/components/input/test/auro-input.test.js b/components/input/test/auro-input.test.js
@@ -1,4 +1,4 @@
-import { fixture, html, expect, elementUpdated, oneEvent } from '@open-wc/testing';
+import { fixture, html, expect, elementUpdated, oneEvent, nextFrame } from '@open-wc/testing';
 import '../src/index.js';
 
 describe('auro-input', () => {
@@ -68,7 +68,8 @@ describe('auro-input', () => {
 
     const clearButton = el.shadowRoot.querySelector('.clearBtn');
     clearButton.click();
-    expect(el.value).to.be.undefined;
+    await elementUpdated();
+    expect(el.value).to.equal('');
   });
 
   it('flips hide-password bit', async () => {
@@ -183,6 +184,7 @@ describe('auro-input', () => {
     input.blur();
 
     await elementUpdated(el);
+    await nextFrame();
 
     expect(el.hasAttribute('validity')).to.be.true;
   });