Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROPDOWN: Issues around focus border #129

Closed
jordanjones243 opened this issue Dec 18, 2024 · 1 comment · Fixed by #130
Closed

DROPDOWN: Issues around focus border #129

jordanjones243 opened this issue Dec 18, 2024 · 1 comment · Fixed by #130
Assignees
Labels
auro-form Type: Bug Bug or Bug fixes

Comments

@jordanjones243
Copy link
Contributor

Please verify the version of auro-form you have installed

1.5.0

Please describe the bug

  1. Open dropdown locally
  2. Navigate to API page
  3. Click on basic dropdown
  4. See error
Screen Shot 2024-12-18 at 1 11 06 PM

Reproducing the error

This issue is reproducible on the Auro docsite

Expected behavior

There should be a focus border around the trigger when the dropdown or its children have focus

What browsers are you seeing the problem on?

Chrome

Additional context

There also seems to be issues around the error use cases. We should be seeing the same 2px blue border when the trigger has focus, but we only see 1px borders or no change at all:
Screen Shot 2024-12-18 at 1 13 36 PM
Screen Shot 2024-12-18 at 1 13 47 PM

Exit criteria

All border colors are applied in correct scenarios

@sun-mota
Copy link
Contributor

sun-mota added a commit that referenced this issue Dec 19, 2024
sun-mota added a commit that referenced this issue Dec 19, 2024
sun-mota added a commit that referenced this issue Dec 19, 2024
@jason-capsule42 jason-capsule42 changed the title DROPDOWN - Issues around focus border DROPDOWN: Issues around focus border Dec 24, 2024
sun-mota added a commit that referenced this issue Dec 27, 2024
sun-mota added a commit that referenced this issue Dec 27, 2024
sun-mota added a commit that referenced this issue Dec 27, 2024
jordanjones243 pushed a commit that referenced this issue Dec 30, 2024
jason-capsule42 pushed a commit that referenced this issue Dec 30, 2024
# [1.6.0-beta.10](v1.6.0-beta.9...v1.6.0-beta.10) (2024-12-30)

### Bug Fixes

* force focus state to dropdown.trigger as `document.activeElement` stays in body even with clicking [#129](#129) ([ce65f18](ce65f18))
* remove extra focus line on chrome ([681e1b4](681e1b4))
* replace `box-shadow` with `outline` ([70c3d3d](70c3d3d))

### Performance Improvements

* update auro-library to fix the focus issue ([1548d20](1548d20))
* update component dependencies ([81dbb5b](81dbb5b))
@sun-mota sun-mota closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-form Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants