Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-counter-group: dropdown height is taller than the design #289

Closed
sun-mota opened this issue Jan 30, 2025 · 0 comments · Fixed by #301
Closed

auro-counter-group: dropdown height is taller than the design #289

sun-mota opened this issue Jan 30, 2025 · 0 comments · Fixed by #301
Assignees
@rmenner
Labels
auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes

Comments

@sun-mota
Copy link
Contributor

Please verify the version of auro-form you have installed

No response

Please describe the bug

With label slot, counter-group dropdown is 74px height.

Image

the height should be always 56px with or without label, like auro-select

Reproducing the error

None

Expected behavior

No response

What browsers are you seeing the problem on?

No response

Additional context

No response

Exit criteria

No response
@sun-mota sun-mota added auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Jan 30, 2025
@sun-mota sun-mota mentioned this issue Feb 3, 2025
Open
rmenner added a commit that referenced this issue Feb 5, 2025
@rmenner
fix: adjust max-height for dropdown trigger in counter-group styles #289
b55b6de
@rmenner rmenner self-assigned this Feb 5, 2025
@rmenner rmenner linked a pull request Feb 5, 2025 that will close this issue
Counter max height #301
Merged
rmenner added a commit that referenced this issue Feb 5, 2025
@rmenner
fix: adjust max-height for dropdown trigger in counter-group styles #289
ff1682d
rmenner added a commit that referenced this issue Feb 5, 2025
@rmenner
fix: adjust max-height for dropdown trigger in counter-group styles #289
af6b33a
rmenner added a commit that referenced this issue Feb 5, 2025
@rmenner
fix: adjust max-height for dropdown trigger in counter-group styles #289
1aa464a
jason-capsule42 pushed a commit that referenced this issue Feb 5, 2025
@semantic-release-bot
chore(release): 2.0.0-beta.35 [skip ci]
baeaa01 
# [2.0.0-beta.35](v2.0.0-beta.34...v2.0.0-beta.35) (2025-02-05)

### Bug Fixes

* adjust max-height for dropdown trigger in counter-group styles [#289](#289) ([1aa464a](1aa464a))
* change overflow property to hidden for trigger and valueText slots ([64e9994](64e9994))
@rmenner rmenner closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmenner rmenner

Labels
auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Counter max height AlaskaAirlines/auro-formkit
3 participants
@rmenner @sun-mota @Patrick-Daly-AA