Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROPDOWN: Add padding between the trigger and bib #56

Closed
jordanjones243 opened this issue Nov 20, 2024 · 1 comment · Fixed by #104
Closed

DROPDOWN: Add padding between the trigger and bib #56

jordanjones243 opened this issue Nov 20, 2024 · 1 comment · Fixed by #104
Assignees

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Nov 20, 2024

General Support Request

As outlined in the blueprint, 4px of space is expected between the trigger and bib.

Possible Solution

Update styles to reflect these changes

Exit criteria

Space is added between trigger and bib and component matches blueprint:

@jordanjones243 jordanjones243 added auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels Nov 20, 2024
@jordanjones243 jordanjones243 removed not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature auro-form labels Nov 20, 2024
@chrisfalaska chrisfalaska changed the title Add padding between the trigger and bib Dropdown: Add padding between the trigger and bib Nov 26, 2024
@jason-capsule42 jason-capsule42 changed the title Dropdown: Add padding between the trigger and bib DROPDOWN: Add padding between the trigger and bib Dec 3, 2024
rmenner pushed a commit that referenced this issue Dec 16, 2024
# [1.6.0-beta.1](v1.5.0...v1.6.0-beta.1) (2024-12-16)

### Bug Fixes

* add back `document.body.append` for the floating bib ([7bd62f8](7bd62f8))
* add OEF line to end of files ([3dd5612](3dd5612))
* add REAME to docs templates ([f9b37ea](f9b37ea))
* add semi-colon to end of version files ([8d523b1](8d523b1))
* add space between bib and trigger [#56](#56) ([d936fd4](d936fd4))
* add versionWriter back to menu ([9bd9d50](9bd9d50))
* adding default component package files ([028c236](028c236))
* check in doc after build ([76f8027](76f8027))
* clarify dependency nature in docs ([cc5ff59](cc5ff59))
* clarify development environment in docs ([7f0a7ce](7f0a7ce))
* clarify development environment in docs ([82e051a](82e051a))
* clean up dropdown version imports  after merge ([07b0815](07b0815))
* commit generated readme ([a3f9917](a3f9917))
* correct path typo ([ce79afa](ce79afa))
* **docs:** fix typo in Dialog example md ([5028ff1](5028ff1))
* dropdown dev port ([23b0f96](23b0f96))
* export components for typescript support ([b940403](b940403))
* export Dropdown & Import so Combobox can consume ([18d5103](18d5103))
* fix missing bibContent reference ([51eea4a](51eea4a))
* lint update ([9003be7](9003be7))
* linting errors on date-picker vendor file ([c7e01d4](c7e01d4))
* make dropdown to export size to dropdownSize in `exposeCssParts` ([165c0db](165c0db))
* make dropdown's `matchwidth` to stretch out to the trigger width ([4cf5c17](4cf5c17))
* make rollup to proplery generate bundled.js and demo/*.min.js ([c9c5f07](c9c5f07))
* move date-picker vendor files into src ([e3a518d](e3a518d))
* move styles to folder in datepicker ([c98f399](c98f399))
* move styles to folder in menu ([a47ffbd](a47ffbd))
* package names in turbo.json ([ffeed9f](ffeed9f))
* path in script documentation ([663bbe9](663bbe9))
* remove [@todo](https://github.com/todo) from readme ([1a6848a](1a6848a))
* remove date-picker vendor files from root ([76a770d](76a770d))
* remove deprecated dev note ([bf647cf](bf647cf))
* remove deprecated README ([949914f](949914f))
* remove exports field from root package.json ([f7a5294](f7a5294))
* remove periods from config filenames ([606cc1e](606cc1e))
* remove redundant attribute setter ([2a935df](2a935df))
* remove test from husky, correct lint ([e64d26c](e64d26c))
* remove unnecessary tsconfig for config files ([78013a3](78013a3))
* revert automatic port script ([7e719e8](7e719e8))
* revert automatic port script ([ae6614f](ae6614f))
* revert package.json after merge conflicts ([406a497](406a497))
* scope kit doc command to build-tools package ([c7afb5a](c7afb5a))
* specify select's height and remove hack for the bib's `z-index` [#99](#99) ([b2647d4](b2647d4))
* spelling correction ([eff34dc](eff34dc))
* update aria-selected values ([f3f2bdc](f3f2bdc))
* update clean up input after merge ([c7ddea1](c7ddea1))
* update combobox build pipeline ([943c52a](943c52a))
* update component dependencies to workspaces ([343a69b](343a69b))
* update css file imports ([1ab2620](1ab2620))
* update css file imports ([a6269d8](a6269d8))
* update css imports ([c9df970](c9df970))
* update date-picker tsconfig with vendor folder ([7e7346b](7e7346b))
* update dropdown package imports ([00a6360](00a6360))
* update dropdown package name ([69abf2f](69abf2f))
* update dropdown's z-index and update select's height [#98](#98) ([3aa3000](3aa3000))
* update formkit components in docs ([0bfffc1](0bfffc1))
* update formVersionWriter to add semicolon and new line at end for lint ([1c3fb47](1c3fb47))
* update icon versions ([3a3959d](3a3959d))
* update input package imports ([08fd308](08fd308))
* update local formkit version files ([c2e3507](c2e3507))
* update local formkit version files ([6ea877a](6ea877a))
* update local formkit version files ([18dc3d0](18dc3d0))
* update menu package name ([6d2bcff](6d2bcff))
* update package names to use monorepo namespace ([436789f](436789f))
* update package scss imports ([c849b2d](c849b2d))
* update package-lock ([8e13043](8e13043))
* update package.json with new namespace ([da6f29e](da6f29e))
* update package.lock ([877f2c6](877f2c6))
* update README ([9148141](9148141))
* update README path from where package is run ([762ee40](762ee40))
* update readme structure ([44b368b](44b368b))
* update select dependency workspace ([47b0af5](47b0af5))
* update step for testPublish.yml ([63eb5be](63eb5be))
* update turbo to track changes in docs partials ([0b93b80](0b93b80))
* update type setup ([2cf0bcc](2cf0bcc))
* updates to  README ([ce8e5c5](ce8e5c5))
* updating kitDocProcessor ([6ae32c6](6ae32c6))
* watch for script changes in turbo ([e70dd10](e70dd10))

### Features

* add `bibSizer` to help sizing `bibContainer` with css style ([c6e881b](c6e881b))
* add `docProcessor` to generate docs for each components ([23b0f1b](23b0f1b))
* add `mobileFullscreenBreakpoint` instead of `noFullscreenOnMobile` ([1a33257](1a33257))
* add `noFullscreenOnMobile` attribute ([ff98d61](ff98d61))
* add doc partials ([45a6c01](45a6c01))
* add turborepo ([6af0fe4](6af0fe4))
* add wca as part of build:docs ([ba484de](ba484de))
* counter component initial setup [#54](#54) ([df727e3](df727e3))
* initial kitDocProcessor ([77fdb4d](77fdb4d))
* integrate form validation [#44](#44) ([a673a6b](a673a6b))
* open bib fullscreen on mobile view [#55](#55) ([84110fd](84110fd))

### Performance Improvements

* move `.container` our of `:host` ([088acab](088acab))
* prevent semantic-release from running git hooks [#112](#112) ([4134add](4134add))
* revert variable rendering logic for calendar ([ac1899e](ac1899e))
* simplify logic of resetting bib's size on fullscreen mode ([a69ffb1](a69ffb1))
* testing out latest husky to fix release [#112](#112) ([d34fded](d34fded))
* update instances of auro-form the repo to auro-formkit [#35](#35) ([0b5b8d5](0b5b8d5))
* update old build release command [#35](#35) ([b279345](b279345))
@rmenner
Copy link
Contributor

rmenner commented Dec 16, 2024

🎉 This issue has been resolved in version 1.6.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants