-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu: add loadingIcon
slot loadingText
slot and loading
attribute
#124
Conversation
381f155
to
77a9482
Compare
@sourcery-ai review |
Reviewer's Guide by SourceryThis PR adds loading state support to the menu component, which is then integrated into both combobox and select components. The implementation includes a loading attribute that, when set, displays a loading placeholder with optional icon and text slots. The loading state can be customized with loading text and/or a loading icon, or remain empty. Class diagram for updated AuroMenu componentclassDiagram
class AuroMenu {
Boolean loading
Boolean hasLoadingPlaceholder
Event auroMenu-loadingChange
slot loadingText
slot loadingIcon
+get hasLoadingPlaceholder() boolean
}
note for AuroMenu "New loading attribute and slots for loading state"
Class diagram for updated AuroCombobox componentclassDiagram
class AuroCombobox {
Boolean isHiddenWhileLoading
+handleMenuLoadingChange(CustomEvent event)
}
note for AuroCombobox "Handles loading state changes from AuroMenu"
Class diagram for updated AuroSelect componentclassDiagram
class AuroSelect {
Boolean isHiddenWhileLoading
+handleMenuLoadingChange(CustomEvent event)
}
note for AuroSelect "Handles loading state changes from AuroMenu"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 6 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
76b6238
to
72e9cab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
25623e9
to
1b7b32d
Compare
43dc0bc
to
58c39ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This PR is included in version 1.6.0-beta.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
loading
attribute,loadingIcon
andloadingText
slotsBefore Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Add a
loading
attribute andloadingIcon
andloadingText
slots to theauro-menu
component to support loading states, and update related components and documentation to reflect these changes.New Features:
loading
attribute to theauro-menu
component to display a loading state.loadingIcon
andloadingText
slots to theauro-menu
component for customizable loading indicators.Enhancements:
auro-combobox
andauro-select
components to support the newloading
attribute and slots fromauro-menu
.Documentation:
loading
attribute and slots forauro-menu
,auro-combobox
, andauro-select
components.Summary by Sourcery
Add a
loading
attribute andloadingIcon
andloadingText
slots to theauro-menu
component to support loading states, and update related components and documentation to reflect these changes.New Features:
loading
attribute to theauro-menu
component to display a loading state.loadingIcon
andloadingText
slots to theauro-menu
component for customizable loading indicators.Enhancements:
auro-combobox
andauro-select
components to support the newloading
attribute and slots fromauro-menu
.Documentation:
loading
attribute and slots forauro-menu
,auro-combobox
, andauro-select
components.