fix: use label as placeholder when there is no placeholder string set #36

[sun-mota]

Alaska Airlines Pull Request

Closes #36

Before Submitting this pull request:

• Link all tickets in this repository related to this PR in the Development section
  note: all pull requests require at least one linked ticket
• If this PR is Ready For Review, all ticket's linked under Development must have their status changed to Ready For Review as well

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.

Summary by Sourcery

Bug Fixes:

• Fixed an issue where the placeholder text was not displayed correctly when no placeholder string was set.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes an issue where the placeholder text was not displayed correctly when no placeholder string was set. It changes the default placeholder value to an empty string and uses the label as a placeholder when there is no placeholder or value set.

Class diagram for AuroSelect component changes

classDiagram
    class AuroSelect {
        -String placeholder
        -Object optionSelected
        -String validity
        +constructor()
        +render()
    }
    note for AuroSelect "Changed:
    - Default placeholder=''
    - Added asPlaceholder attribute
    - Modified label slot rendering"

Loading

State diagram for select component placeholder behavior

stateDiagram-v2
    [*] --> NoPlaceholder: Initial State
    NoPlaceholder --> ShowLabel: No placeholder & No value
    NoPlaceholder --> ShowValue: Has value
    ShowLabel --> ShowValue: Value selected
    ShowValue --> ShowLabel: Value cleared

    state NoPlaceholder {
        [*] --> EmptyString: Default placeholder=''
    }

    state ShowLabel {
        [*] --> UseLabelAsPlaceholder: asPlaceholder=true
    }

    state ShowValue {
        [*] --> DisplaySelectedValue: asPlaceholder=false
    }

Loading

File-Level Changes

Change	Details	Files
Set default placeholder to empty string and use label as placeholder when appropriate	Changed the default placeholder value to an empty string. Added logic to use the label as placeholder when there is no placeholder or value set. Updated component styles to support label as placeholder behavior. Updated API documentation to reflect the changes in the placeholder behavior.	components/select/demo/api.md components/select/docs/api.md components/select/src/auro-select.js components/select/src/styles/style.scss

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#36	Label should move up when a value is selected and there is no placeholder	✅
#36	Modify the dropdown behavior to match the blueprint design	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @sun-mota - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding unit tests for the new handleLabelSlotChange functionality to ensure the label-as-placeholder behavior works correctly

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sun-mota]

@sourcery-ai review

[sourcery-ai]

Hey @sun-mota - I've reviewed your changes - here's some feedback:

Overall Comments:

• ⚠️ Changing the default placeholder from 'Please select option' to an empty string is a breaking change that could affect existing applications. Please consider if this needs to be documented in release notes or migration guides.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}