-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated non-bordered examples from documentation #180
Conversation
Reviewer's Guide by SourceryThis PR removes the deprecated State diagram showing auro-input attribute changesstateDiagram-v2
direction LR
[*] --> OldState
OldState --> NewState
state OldState {
direction LR
state "auro-input" as OldInput
state "Supports both borderless and bordered" as OldBorder
OldInput --> OldBorder
}
state NewState {
direction LR
state "auro-input" as NewInput
state "Only supports bordered" as NewBorder
NewInput --> NewBorder
}
note right of NewState
Removed deprecated borderless attribute
All examples updated to use bordered
end note
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
f5f011e
to
2a42011
Compare
🎉 This PR is included in version 2.0.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Remove the borderless input examples from the documentation and update the remaining examples to use the bordered attribute.
Documentation:
Tests: