-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix console error when running tests #205
Conversation
Reviewer's Guide by SourceryThis PR fixes a console error that occurred when making an invalid selection programmatically in the Sequence diagram for updated auro-select error handlingsequenceDiagram
participant User
participant AuroSelect
participant State
User->>AuroSelect: Makes invalid selection programmatically
AuroSelect->>State: Reset state
Note over AuroSelect: No error UI shown
AuroSelect-->>User: Continue with reset state
Class diagram showing updated component versionsclassDiagram
class AuroFormkit {
+version: 2.0.0-beta.6
}
AuroFormkit <|-- AuroCheckbox
AuroFormkit <|-- AuroCombobox
AuroFormkit <|-- AuroDatepicker
AuroFormkit <|-- AuroDropdown
AuroFormkit <|-- AuroForm
AuroFormkit <|-- AuroInput
AuroFormkit <|-- AuroMenu
AuroFormkit <|-- AuroRadio
AuroFormkit <|-- AuroSelect
note for AuroSelect "Updated error handling for invalid selections"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
6c99153
to
f81fc34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
f81fc34
to
5560d25
Compare
11e217a
to
3d648dd
Compare
3d648dd
to
f9e4d12
Compare
🎉 This PR is included in version 2.0.0-beta.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Update auro-formkit dependencies to beta.6 and fix a bug where making an invalid selection programmatically results in the component resetting.
Bug Fixes:
Tests: