Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix combobox to close bib on selection and put checkmark properly #207

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

sun-mota
Copy link
Contributor

@sun-mota sun-mota commented Jan 14, 2025

Alaska Airlines Pull Request

Before Submitting this pull request:

  • Link all tickets in this repository related to this PR in the Development section
    note: all pull requests require at least one linked ticket
  • If this PR is Ready For Review, all ticket's linked under Development must have their status changed to Ready For Review as well

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.

Summary by Sourcery

Fix the combobox to close the dropdown menu on selection and display the checkmark correctly.

Bug Fixes:

  • Ensure the dropdown menu closes after a selection is made.
  • Correctly display the checkmark when an option is selected.

@sun-mota sun-mota self-assigned this Jan 14, 2025
@sun-mota sun-mota changed the base branch from main to beta January 14, 2025 18:14
@AlaskaAirlines AlaskaAirlines deleted a comment from CLAassistant Jan 14, 2025
@AlaskaAirlines AlaskaAirlines deleted a comment from sourcery-ai bot Jan 14, 2025
@sun-mota sun-mota marked this pull request as ready for review January 15, 2025 17:30
@sun-mota sun-mota requested a review from a team as a code owner January 15, 2025 17:30
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sun-mota - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief comment explaining the purpose of the hasChange flag and how it optimizes the update flow by preventing unnecessary resets
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sun-mota sun-mota merged commit 685690a into beta Jan 15, 2025
3 checks passed
@sun-mota sun-mota deleted the sunMota/141 branch January 15, 2025 21:48
@jason-capsule42
Copy link
Member

🎉 This PR is included in version 2.0.0-beta.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants