-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(menu): update active/hover color token for menuoption #232
Conversation
Reviewer's Guide by SourceryThis pull request updates the auro-formkit dependencies to beta.14 and fixes an accessibility issue where the active and hover states of menu options were not visually apparent to users. The fix was implemented by updating the color token for the active and hover states of the menu option. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chrisfalaska - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
chrisfalaska seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
🎉 This PR is included in version 2.0.0-beta.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Updates the
active
and:hover
state of menu options to fix an accessibility issue that prevented users from seeing which option was focused.token-update.mp4
Summary by Sourcery
Update auro-checkbox, auro-combobox, auro-counter, auro-datepicker, auro-dropdown, auro-form, auro-input, auro-menu, auro-radio, and auro-select to the latest beta versions.
Bug Fixes:
Enhancements: