Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): update active/hover color token for menuoption #232

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

chrisfalaska
Copy link
Contributor

@chrisfalaska chrisfalaska commented Jan 17, 2025

Updates the active and :hover state of menu options to fix an accessibility issue that prevented users from seeing which option was focused.

token-update.mp4

Summary by Sourcery

Update auro-checkbox, auro-combobox, auro-counter, auro-datepicker, auro-dropdown, auro-form, auro-input, auro-menu, auro-radio, and auro-select to the latest beta versions.

Bug Fixes:

  • Fix accessibility issue where users could not see which menu option was focused.

Enhancements:

  • Update design tokens for active and hover states of menu options.

@chrisfalaska chrisfalaska self-assigned this Jan 17, 2025
Copy link

sourcery-ai bot commented Jan 17, 2025

Reviewer's Guide by Sourcery

This pull request updates the auro-formkit dependencies to beta.14 and fixes an accessibility issue where the active and hover states of menu options were not visually apparent to users. The fix was implemented by updating the color token for the active and hover states of the menu option.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated auro-formkit dependencies to beta.14.
  • Updated the version of auro-dropdown.
  • Updated the version of auro-input.
  • Updated the version of auro-menu.
  • Updated the version of auro-combobox.
  • Updated the version of auro-popover.
  • Updated the version of auro-datepicker.
  • Updated the version of auro-select.
  • Updated the version of auro-checkbox.
  • Updated the version of auro-counter.
  • Updated the version of auro-form.
  • Updated the version of auro-radio.
components/combobox/README.md
components/datepicker/README.md
components/select/README.md
components/checkbox/README.md
components/counter/README.md
components/dropdown/README.md
components/form/README.md
components/input/README.md
components/menu/README.md
components/radio/README.md
Updated the active and hover state color token for menu options.
  • Added a style rule to change the background color of the menu option when it is hovered or active.
components/menu/src/styles/color-menuoption.scss
Removed the active class toggle from the menu component.
  • Removed the line that toggles the 'active' class on the menu option.
components/menu/src/auro-menu.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@chrisfalaska chrisfalaska linked an issue Jan 17, 2025 that may be closed by this pull request
@chrisfalaska chrisfalaska marked this pull request as ready for review January 17, 2025 19:42
@chrisfalaska chrisfalaska requested a review from a team as a code owner January 17, 2025 19:42
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chrisfalaska - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

jordanjones243
jordanjones243 previously approved these changes Jan 17, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


chrisfalaska seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chrisfalaska chrisfalaska merged commit c5b2dce into beta Jan 17, 2025
3 of 4 checks passed
@chrisfalaska chrisfalaska deleted the cfriedberg/149 branch January 17, 2025 19:59
@jason-capsule42
Copy link
Member

🎉 This PR is included in version 2.0.0-beta.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-menu a11y/UX issue when selected
4 participants