-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add checkbox into components #27 #32
Conversation
Reviewer's Guide by SourceryThis PR adds a new checkbox component (v4.1.0) to the auro-formkit library. The implementation includes the main checkbox component, checkbox group functionality, and necessary build configurations. The changes primarily focus on adding new component files and updating build scripts to support the checkbox component. Class diagram for the new checkbox componentclassDiagram
class AuroCheckbox {
- Boolean checked
- Boolean disabled
- Boolean error
- String id
- String name
- String value
+ handleChange(event)
+ handleInput(event)
+ handleFocusin()
+ generateIconHtml()
}
class AuroCheckboxGroup {
- String validity
- Array value
- Boolean disabled
- Boolean required
- Boolean horizontal
- AuroFormValidation validation
- AuroLibraryRuntimeUtils runtimeUtils
+ handleValueUpdate(value, selected)
+ handlePreselectedItems()
+ handleItems()
}
AuroCheckboxGroup --> AuroCheckbox : contains
note for AuroCheckbox "Custom element for selecting options"
note for AuroCheckboxGroup "Wrapper for AuroCheckbox elements"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟡 Complexity: 2 issues found
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
7fb0f7d
to
4f23209
Compare
bc93430
to
b58b1e1
Compare
Alaska Airlines Pull Request
#27
rollup.config
to add demo's config to bundler (each component should haveindex.js
andapi.js
under/demo
)By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Add a new checkbox component to the auro-formkit, update build scripts to support it, and provide detailed documentation and examples.
New Features:
Enhancements:
Documentation: