-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: integrate datepicker with the internal dropdown #69
Conversation
Reviewer's Guide by SourceryThis PR refactors the auro-datepicker component to use an internal auro-dropdown component, improving the component's modularity. The main changes involve restructuring how the calendar is accessed through the dropdown and updating the event handling logic. The tests have been updated to reflect this new structure. Sequence diagram for AuroDatePicker and AuroDropdown interactionsequenceDiagram
participant User
participant AuroDatePicker
participant AuroDropdown
participant AuroCalendar
User->>AuroDatePicker: Select date
AuroDatePicker->>AuroDropdown: Open dropdown
AuroDropdown->>AuroCalendar: Display calendar
AuroCalendar->>AuroDatePicker: Date selected
AuroDatePicker->>AuroDropdown: Close dropdown
AuroDatePicker->>User: Confirm date selection
Updated class diagram for AuroDatePicker integration with AuroDropdownclassDiagram
class AuroDatePicker {
- configureCalendar()
- configureDatepicker()
- handleReadOnly()
- notifyReady() // Removed
- ready // Removed
+ calendar: AuroCalendar
+ dropdown: AuroDropdown
}
class AuroCalendar {
+ datepicker: AuroDatePicker
+ calendarStartDate
+ calendarEndDate
+ centralDate
}
class AuroCalendarCell {
+ datepicker: AuroDatePicker
+ calendarMonth: AuroCalendarMonth
+ auroPopover: AuroPopover
+ firstUpdated()
+ updated(properties)
}
AuroDatePicker --> AuroCalendar
AuroCalendarCell --> AuroDatePicker
AuroCalendarCell --> AuroCalendarMonth
AuroCalendarCell --> AuroPopover
AuroCalendar --> AuroDatePicker
note for AuroDatePicker "Refactored to integrate with AuroDropdown"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
e8c9c7a
to
5c6c131
Compare
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
5a5a986
to
12b16b0
Compare
12b16b0
to
6246c0d
Compare
6246c0d
to
d6077b6
Compare
…ariable in calendar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All new files in this PR need to have and EOF extra line. I would suggest turning on the feature in VS Code that does this for you by default when saving a file.
https://stackoverflow.com/questions/44704968/visual-studio-code-insert-newline-at-the-end-of-files
🎉 This PR is included in version 1.6.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Refactor the datepicker component to integrate with the internal dropdown, enhancing the component's structure and updating tests accordingly.
Enhancements:
Tests: