-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make rollup to proplery generate bundled.js and demo/*.min.js #88
Conversation
Reviewer's Guide by SourceryThis PR simplifies the Rollup configuration by removing component-specific build configurations and standardizing the build process. The changes primarily focus on streamlining the bundling configuration and updating the file paths for demo files. Class diagram for updated Rollup configurationclassDiagram
class RollupConfig {
-getComponentEntryPoints()
+createConfig(name, input, output)
+createExampleConfig(entryPoint)
}
class MainConfig {
+createConfig('formkit', './src/index.js', 'dist')
}
class ExampleConfig {
+createExampleConfig('index')
+createExampleConfig('api')
}
RollupConfig --> MainConfig
RollupConfig --> ExampleConfig
note for RollupConfig "Simplified by removing component-specific configurations"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide documentation explaining the rationale behind removing dynamic component discovery and centralizing the demo structure. These architectural changes should be justified in the PR description.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
3a6c124
to
fec3882
Compare
fec3882
to
50a5eaf
Compare
50a5eaf
to
6684c11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
🎉 This PR is included in version 1.6.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Bug Fixes: