Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make rollup to proplery generate bundled.js and demo/*.min.js #88

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

sun-mota
Copy link
Contributor

@sun-mota sun-mota commented Dec 4, 2024

Alaska Airlines Pull Request

Before Submitting this pull request:

  • Link all tickets in this repository related to this PR in the Development section
    note: all pull requests require at least one linked ticket
  • If this PR is Ready For Review, all ticket's linked under Development must have their status changed to Ready For Review as well

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.

Summary by Sourcery

Bug Fixes:

  • Fix the Rollup configuration to properly generate bundled.js and demo/*.min.js files.

@sun-mota sun-mota self-assigned this Dec 4, 2024
@sun-mota sun-mota requested a review from a team as a code owner December 4, 2024 22:37
Copy link

sourcery-ai bot commented Dec 4, 2024

Reviewer's Guide by Sourcery

This PR simplifies the Rollup configuration by removing component-specific build configurations and standardizing the build process. The changes primarily focus on streamlining the bundling configuration and updating the file paths for demo files.

Class diagram for updated Rollup configuration

classDiagram
    class RollupConfig {
        -getComponentEntryPoints()
        +createConfig(name, input, output)
        +createExampleConfig(entryPoint)
    }

    class MainConfig {
        +createConfig('formkit', './src/index.js', 'dist')
    }

    class ExampleConfig {
        +createExampleConfig('index')
        +createExampleConfig('api')
    }

    RollupConfig --> MainConfig
    RollupConfig --> ExampleConfig

    note for RollupConfig "Simplified by removing component-specific configurations"
Loading

File-Level Changes

Change Details Files
Simplified Rollup configuration by removing component-specific build logic
  • Removed getComponentEntryPoints function that was scanning for component entry points
  • Removed component configs generation from the default export
  • Updated main config to use './src/index.js' as the entry point
  • Simplified demo configuration to handle index and api files directly
packages/config/src/rollup.config.mjs
Standardized bundler script configuration across all components
  • Removed --input parameter from bundler script command
  • Updated all components to use the same bundler configuration
components/checkbox/package.json
components/combobox/package.json
components/datepicker/package.json
components/dropdown/package.json
components/form/package.json
components/input/package.json
components/menu/package.json
components/radio/package.json
components/select/package.json
Updated demo file path structure
  • Changed demo file output directory from component-specific to root demo directory
  • Updated path handling for demo files in the Rollup configuration
components/combobox/demo/api.min.js
components/combobox/demo/index.min.js
components/datepicker/demo/api.min.js
components/datepicker/demo/index.min.js
components/dropdown/demo/api.min.js
components/dropdown/demo/index.min.js
components/input/demo/api.min.js
components/input/demo/index.min.js
components/menu/demo/api.min.js
components/menu/demo/index.min.js
components/select/demo/api.min.js
components/select/demo/index.min.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sun-mota sun-mota linked an issue Dec 4, 2024 that may be closed by this pull request
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sun-mota - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide documentation explaining the rationale behind removing dynamic component discovery and centralizing the demo structure. These architectural changes should be justified in the PR description.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

components/combobox/demo/api.min.js Outdated Show resolved Hide resolved
components/combobox/demo/api.min.js Outdated Show resolved Hide resolved
components/combobox/demo/api.min.js Outdated Show resolved Hide resolved
components/combobox/demo/api.min.js Outdated Show resolved Hide resolved
components/combobox/demo/api.min.js Outdated Show resolved Hide resolved
components/combobox/demo/api.min.js Show resolved Hide resolved
components/combobox/demo/api.min.js Show resolved Hide resolved
components/combobox/demo/api.min.js Show resolved Hide resolved
components/combobox/demo/api.min.js Show resolved Hide resolved
components/combobox/demo/api.min.js Show resolved Hide resolved
@sun-mota sun-mota force-pushed the sunMota/fix-bundler branch from 3a6c124 to fec3882 Compare December 4, 2024 23:08
@sun-mota sun-mota force-pushed the sunMota/fix-bundler branch from fec3882 to 50a5eaf Compare December 4, 2024 23:19
@sun-mota sun-mota force-pushed the sunMota/fix-bundler branch from 50a5eaf to 6684c11 Compare December 4, 2024 23:19
Copy link
Contributor

@chrisfalaska chrisfalaska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@sun-mota sun-mota merged commit 2ce7138 into main Dec 4, 2024
4 of 6 checks passed
@sun-mota sun-mota deleted the sunMota/fix-bundler branch December 4, 2024 23:43
@rmenner
Copy link
Contributor

rmenner commented Dec 16, 2024

🎉 This PR is included in version 1.6.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bundler does not work
3 participants