-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate form validation #96
Conversation
Reviewer's Guide by SourceryThis PR introduces a new shared validation module for form components in the auro-formkit monorepo. The implementation involves migrating from the existing @aurodesignsystem/auro-formvalidation package to a new internal @auro-formkit/validation package, which provides consistent validation logic across all form components. Class diagram for AuroFormValidationclassDiagram
class AuroFormValidation {
+AuroLibraryRuntimeUtils runtimeUtils
+validateAttributes(elem)
+validateType(elem)
+validate(elem, force)
+getInputElements(elem)
+getAuroInputs(elem)
+getErrorMessage(elem)
}
class AuroLibraryRuntimeUtils
AuroFormValidation --> AuroLibraryRuntimeUtils
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
c73b947
to
0259807
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the console.log statement from the AuroFormValidation constructor as it appears to be debug code
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
0259807
to
c16aec6
Compare
b452549
to
33dfcbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
4a51d50
to
c3359dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisfalaska might know better, but I think, since all other components are using form-validation, @auro-formkit/typescript/base.json
should be added to dependsOn
in build
config in turbo.json
bdb7f7f
to
7088ca6
Compare
7088ca6
to
7c75a8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
🎉 This PR is included in version 1.6.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Integrate a new shared validation package for form components, replacing the existing '@aurodesignsystem/auro-formvalidation' dependency with '@auro-formkit/validation' across various components. This change centralizes form validation logic and improves maintainability.
New Features:
Enhancements: