Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-header: independent top/bottom margins #4

Closed
ftaylor-alaska opened this issue Sep 9, 2020 · 2 comments
Closed

auro-header: independent top/bottom margins #4

ftaylor-alaska opened this issue Sep 9, 2020 · 2 comments
Assignees
@blackfalcon
Labels
Type: Feature New Feature

Comments

@ftaylor-alaska
Copy link
Member

Is your feature request related to a problem? Please describe.

Consumers of the auro-header are limited to adjust either the top or bottom margin, but not both.

Describe the solution you'd like

As a developer for AScom, I would like to see the auro-header have the ability to specify both the top and bottom margin adjustments. (Having full independent control of both top and bottom would be a nice-to-have, but the below alternative should be fine).

Describe alternatives you've considered

A simpler solution would be to have the option to set top/bottom margin to be both be the same 'size' value.

Additional context

Currently these are the two attributes which allow the consumer of this component to adjust the top or bottom:
image
@ftaylor-alaska ftaylor-alaska added the Type: Feature New Feature label Sep 9, 2020
@blackfalcon
Copy link
Member

Help to better understand the use case. Is the option that the top/bottom adjustments would be identical or independent. E.g. Top xs, Bottom lg, or Top/Bottom lg.

@ftaylor-alaska
Copy link
Member Author

I think that we would like to have the prior example (top - xs, bottom - lg)

blackfalcon added a commit that referenced this issue Sep 16, 2020
@blackfalcon
feat: #4 add support for BOTH top and bottom margin adjustments at th…
0b69f87 
…e same time
AuroDesignSystem pushed a commit that referenced this issue Sep 16, 2020
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
f26a2d3 
# [1.3.0](v1.2.1...v1.3.0) (2020-09-16)

### Features

* [#4](#4) add support for BOTH top and bottom margin adjustments at the same time ([0b69f87](0b69f87))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blackfalcon @AuroDesignSystem @ftaylor-alaska