Node 18+ updates #84

fajar-apri-alaska · 2023-04-14T09:20:58Z

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #63, #61, #62, #64, #65, #66, #68, #69, #70

Summary:

...

Type of change:

Revision of an existing capability

Checklist:

My update follows the CONTRIBUTING guidelines of this project
I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- JetStream Design System Team

CLAassistant · 2023-04-14T09:21:05Z

All committers have signed the CLA.

blackfalcon · 2023-04-14T18:56:53Z

web-test-runner.config.mjs

+      lines: 80
+    }
+  }
+};


Please always add a new line at the end of the file.

Will do, thanks for the reminder.

blackfalcon · 2023-04-14T18:58:23Z

rollup.config.mjs

+  ]
+};
+
+export default [modernConfig];


Please always have a new line at the end of a file.

Will do, thanks for the reminder.

fajar-apri-alaska · 2023-04-17T09:45:13Z

Hi @blackfalcon, the "Test and publish" check is failing again, I did npm install in latest node 18.
Any other configuration that is missing from my side?

blackfalcon · 2023-04-17T14:44:48Z

Hi @blackfalcon, the "Test and publish" check is failing again, I did npm install in latest node 18. Any other configuration that is missing from my side?

When running into these issues, please review the error logs in the actions UI. This is the issue.
https://github.com/AlaskaAirlines/auro-header/actions/runs/4719720581/jobs/8370882711#step:4:17

This is the fix
https://github.com/AlaskaAirlines/auro-header/actions/runs/4719720581/jobs/8370882711#step:4:29

You should have also seen this in your localhost logs.

blackfalcon · 2023-04-17T14:46:15Z

@fajar-apri-alaska I see that you are adding the links to the issues in progress in the PR message itself, please also add these references in the DEVELOPMENT section of the PR as well.

blackfalcon · 2023-04-17T17:02:11Z

@fajar-apri-alaska it's important that you add the correct information into the body of the commit message. The following commit is missing the BREAKING CHANGE message that it requires.

Please see this example from auro-badge.
AlaskaAirlines/auro-badge@2812f8d

blackfalcon

There are missing updates. Please reference the following updates.

Remove this file and its related resources
https://github.com/AlaskaAirlines/auro-header/blob/fajarapri/node18update/scripts/polyfills.js

src/auro-header.js

package.json

tsconfig.json

.github/ISSUE_TEMPLATE/bug_report.yml

.github/ISSUE_TEMPLATE/general-support.yml

src/style-fixed.scss

The following outlines the steps needed for updating any repo to the latest version of Husky. - npx husky-init - npm i @open-wc/testing@latest @web/test-runner@latest @web/dev-server@latest --save-dev - npm run prepare - chmod ug+x .husky/* - chmod ug+x .git/hooks/* - Update package.json - "test": "wtr --coverage", and "test:watch": "wtr --watch", - Add web-test-runner.config.mjs - Update .husky/pre-commit and necessary pre-commit actions - Delete legacy Husky configs from package.json - Delete karma.conf.js file - Uninstall @open-wc/testing-karma Changes to be committed: new file: .husky/pre-commit deleted: karma.conf.js modified: package-lock.json modified: package.json new file: web-test-runner.config.mjs

Changes to be committed: modified: README.md deleted: babel.config.js modified: package-lock.json modified: package.json deleted: rollup.config.js new file: rollup.config.mjs deleted: src/es5.js

Changes to be committed: modified: .github/workflows/testPublish.yml modified: package-lock.json modified: package.json modified: src/style-fixed.scss modified: src/style.scss

Changes to be committed: modified: .npmignore

Changes to be committed: new file: .editorconfig

This issue updates the bug report template to clarify some of the content when form is completed. Changes to be committed: modified: .github/ISSUE_TEMPLATE/bug_report.yml

malformed / incorrect yml code Changes to be committed: modified: .github/ISSUE_TEMPLATE/general-support.yml

This commit removes legacy content from current resources and deleted files that are no longer required. Changes to be committed: modified: README.md deleted: demo/alert.js modified: demo/index.html deleted: demo/index_old.html deleted: demo/sass/style.scss deleted: polymer.json

Changes to be committed: modified: package-lock.json modified: package.json

Changes to be committed: modified: package.json

Changes to be committed: deleted: scripts/postinstall.js

Changes to be committed: modified: .github/ISSUE_TEMPLATE/general-support.yml

Changes to be committed: modified: package.json

Changes to be committed: deleted: index.html

blackfalcon · 2023-04-19T18:03:05Z

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

fajar-apri-alaska added this to the Header: Node 18+ support milestone Apr 14, 2023

fajar-apri-alaska self-assigned this Apr 14, 2023

fajar-apri-alaska linked an issue Apr 14, 2023 that may be closed by this pull request

Remove legacy es5 bundling resources #61

Closed

fajar-apri-alaska changed the title ~~perf(husky): Pre-commit and husky update #63~~ Node 18+ updates Apr 14, 2023

fajar-apri-alaska force-pushed the fajarapri/node18update branch from 263458a to 91af5f4 Compare April 14, 2023 10:29

This was linked to issues Apr 14, 2023

Update Sass to use dart-sass dependency #62

Closed

Pre-commit and husky update #63

Closed

blackfalcon self-requested a review April 14, 2023 19:12

blackfalcon force-pushed the fajarapri/node18update branch from c08a6f7 to 2a9db8b Compare April 14, 2023 19:16

blackfalcon requested changes Apr 14, 2023

View reviewed changes

This was linked to issues Apr 17, 2023

Update core features to support node 18 #64

Closed

Single CLI support #65

Closed

Update to Lit2.0 #66

Closed

Add tsconfig support #68

Closed

Update issue templates #69

Closed

Update npm namespace #70

Closed

fajar-apri-alaska force-pushed the fajarapri/node18update branch from 324d89a to 975b405 Compare April 18, 2023 05:17

fajar-apri-alaska linked an issue Apr 18, 2023 that may be closed by this pull request

Release is missing required assets #86

Closed

blackfalcon requested changes Apr 18, 2023

View reviewed changes

blackfalcon force-pushed the fajarapri/node18update branch 2 times, most recently from f643658 to 0989708 Compare April 18, 2023 21:26

fajar-apri-alaska force-pushed the fajarapri/node18update branch from 6a302f1 to 062ddb4 Compare April 19, 2023 07:16

fajar-apri-alaska added 3 commits April 19, 2023 10:16

perf(es5): Remove legacy es5 bundling resources #61

57ca022

Changes to be committed: modified: README.md deleted: babel.config.js modified: package-lock.json modified: package.json deleted: rollup.config.js new file: rollup.config.mjs deleted: src/es5.js

perf(sass): Update Sass to use dart-sass dependency #62

82986bf

Changes to be committed: modified: .github/workflows/testPublish.yml modified: package-lock.json modified: package.json modified: src/style-fixed.scss modified: src/style.scss

fajar-apri-alaska added 12 commits April 19, 2023 10:18

Release is missing required assets #86

3eb33ab

Changes to be committed: modified: .npmignore

chore(config): add .editorconfig file

0e5b221

Changes to be committed: new file: .editorconfig

perf(postCss): update to postCss.js & remove unused resource

587177d

chore(scripts): remove polyfills

5a3e1e3

chore: remove extra space in staticStyles-template.js

9939129

fix: misimport pathto 'lit' package in auro-header.js

30853a7

docs(issues): update bug_report template

3596d9e

This issue updates the bug report template to clarify some of the content when form is completed. Changes to be committed: modified: .github/ISSUE_TEMPLATE/bug_report.yml

chore(tsconfig): add extra line to the end of file

26df857

chore: update to typescript package as a dev dependency

7a0d6e0

docs(issues): fix to general-support

e4f921b

malformed / incorrect yml code Changes to be committed: modified: .github/ISSUE_TEMPLATE/general-support.yml

chore: remove style-fixed.scss file

d1667e7

chore(deps): full dependency update

c5786a1

blackfalcon force-pushed the fajarapri/node18update branch from 062ddb4 to c5786a1 Compare April 19, 2023 17:18

blackfalcon added 6 commits April 19, 2023 10:28

deps: remove unused resources

e107690

Changes to be committed: modified: package-lock.json modified: package.json

build(husky): remove package.json config #63

f4cc4de

Changes to be committed: modified: package.json

perf(es5): remove postinstall instrucions #61

8a6deea

Changes to be committed: deleted: scripts/postinstall.js

chore: update line return

0845c7e

Changes to be committed: modified: .github/ISSUE_TEMPLATE/general-support.yml

chore(deps): update peer deps to match dev deps version

f8d2f34

Changes to be committed: modified: package.json

blackfalcon marked this pull request as ready for review April 19, 2023 17:49

blackfalcon requested a review from a team as a code owner April 19, 2023 17:49

blackfalcon self-requested a review April 19, 2023 17:49

blackfalcon previously approved these changes Apr 19, 2023

View reviewed changes

chore: remove unused resource

9f4c8f4

Changes to be committed: deleted: index.html

blackfalcon dismissed their stale review via 9f4c8f4 April 19, 2023 17:58

blackfalcon approved these changes Apr 19, 2023

View reviewed changes

blackfalcon merged commit 0dfce2f into master Apr 19, 2023

blackfalcon deleted the fajarapri/node18update branch April 19, 2023 18:00

blackfalcon added the released Completed work has been released label Apr 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node 18+ updates #84

Node 18+ updates #84

fajar-apri-alaska commented Apr 14, 2023 •

edited

Loading

CLAassistant commented Apr 14, 2023 •

edited

Loading

blackfalcon Apr 14, 2023

fajar-apri-alaska Apr 17, 2023

blackfalcon Apr 14, 2023

fajar-apri-alaska Apr 17, 2023

fajar-apri-alaska commented Apr 17, 2023

blackfalcon commented Apr 17, 2023

blackfalcon commented Apr 17, 2023

blackfalcon commented Apr 17, 2023

blackfalcon left a comment

blackfalcon commented Apr 19, 2023

Node 18+ updates #84

Node 18+ updates #84

Conversation

fajar-apri-alaska commented Apr 14, 2023 • edited Loading

Alaska Airlines Pull Request

Summary:

Type of change:

Checklist:

CLAassistant commented Apr 14, 2023 • edited Loading

blackfalcon Apr 14, 2023

Choose a reason for hiding this comment

fajar-apri-alaska Apr 17, 2023

Choose a reason for hiding this comment

blackfalcon Apr 14, 2023

Choose a reason for hiding this comment

fajar-apri-alaska Apr 17, 2023

Choose a reason for hiding this comment

fajar-apri-alaska commented Apr 17, 2023

blackfalcon commented Apr 17, 2023

blackfalcon commented Apr 17, 2023

blackfalcon commented Apr 17, 2023

blackfalcon left a comment

Choose a reason for hiding this comment

blackfalcon commented Apr 19, 2023

fajar-apri-alaska commented Apr 14, 2023 •

edited

Loading

CLAassistant commented Apr 14, 2023 •

edited

Loading