Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom element unique naming and version control #151

Closed
jason-capsule42 opened this issue Jan 13, 2023 · 0 comments · Fixed by #152 or #154
Closed

Support custom element unique naming and version control #151

jason-capsule42 opened this issue Jan 13, 2023 · 0 comments · Fixed by #152 or #154
Assignees
@jason-capsule42
Labels
auro-hyperlink Type: Feature New Feature

Comments

@jason-capsule42
Copy link
Member

jason-capsule42 commented Jan 13, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Refactor the component so the CE define is not part of the default export. This will allow for custom CE definitions that will improve the versioning issues we currently face.

Describe the solution you'd like

Separate the define(name) method out of the default export.

Create a new registerComponent(name) method in index.js for easy registration of uniquely named components.

Cleanup the build commands and tests to account for new usage.

Additional context

This article gives a fantastic explanation of the issue: https://dev.to/florianrappl/versioning-web-components-3bda
@jason-capsule42 jason-capsule42 added Type: Feature New Feature auro-hyperlink not-reviewed Issue has not been reviewed by Auro team members labels Jan 13, 2023
@jason-capsule42 jason-capsule42 self-assigned this Jan 13, 2023
jason-capsule42 added a commit that referenced this issue Jan 13, 2023
@jason-capsule42
feat(customization): initial feature for custom component versioning #…
5810f7d 
…151
jason-capsule42 added a commit that referenced this issue Jan 16, 2023
@jason-capsule42
refactor(export): change process for CE usage #151
0b42db3 
BREAKING CHANGE: The import and usage has changed.
jason-capsule42 added a commit that referenced this issue Jan 16, 2023
@jason-capsule42
feat(customization): initial feature for custom component versioning #…
870d915 
…151
jason-capsule42 added a commit that referenced this issue Jan 16, 2023
@jason-capsule42
refactor(export): change process for CE usage #151
ece1751 
BREAKING CHANGE: The import and usage has changed.
@jason-capsule42 jason-capsule42 mentioned this issue Jan 16, 2023
Merged
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Jan 16, 2023 that will close this issue
Refactor of how the CE is exported and used #152
Merged
6 tasks
@jordanjones243 jordanjones243 mentioned this issue Jan 18, 2023
Closed
30 tasks
@blackfalcon blackfalcon linked a pull request Jan 18, 2023 that will close this issue
refactor: update to use root index.js #154
Merged
6 tasks
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Jan 24, 2023
blackfalcon pushed a commit that referenced this issue Jan 25, 2023
@jason-capsule42 @blackfalcon
refactor(install): change process for CE use #151
b50cfc7 
This commit dramatically refactors how custom elements
are registered with the browser upon user install.

Changes to be committed:
modified:   demo/index.html
modified:   index.html
renamed:    src/define.js -> src/index.js
modified:   test/auro-hyperlink.test.js
blackfalcon pushed a commit that referenced this issue Jan 25, 2023
@jason-capsule42 @blackfalcon
feat(customization): allow for CE class extension and customization #151
1b19178 


Changes to be committed:
modified:   demo/index.html
modified:   src/define.js
deleted:    src/defineCustom.js
modified:   test/auro-hyperlink.test.js
blackfalcon pushed a commit that referenced this issue Jan 25, 2023
@jason-capsule42 @blackfalcon
refactor(install): change process for CE use #151
aa9c843 
This commit dramatically refactors how custom elements
are registered with the browser upon user install.

Changes to be committed:
modified:   demo/index.html
modified:   index.html
renamed:    src/define.js -> src/index.js
modified:   test/auro-hyperlink.test.js
jason-capsule42 added a commit that referenced this issue Jan 25, 2023
@jason-capsule42
feat(customization): allow for CE class extension and customization #151
6b6a3f9 


Changes to be committed:
modified:   demo/index.html
modified:   src/define.js
deleted:    src/defineCustom.js
modified:   test/auro-hyperlink.test.js
jason-capsule42 added a commit that referenced this issue Jan 25, 2023
@jason-capsule42
refactor(install): change process for CE use #151
7d1f37c 
This commit dramatically refactors how custom elements
are registered with the browser upon user install.

Changes to be committed:
modified:   demo/index.html
modified:   index.html
renamed:    src/define.js -> src/index.js
modified:   test/auro-hyperlink.test.js
blackfalcon pushed a commit that referenced this issue Jan 25, 2023
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
4da77e7 
# [3.3.0](v3.2.2...v3.3.0) (2023-01-25)

### Features

* **customization:** allow for CE class extension and customization [#151](#151) ([6b6a3f9](6b6a3f9))
* **define:** custom CE definitions ([94de68b](94de68b))
@blackfalcon blackfalcon mentioned this issue Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jason-capsule42 jason-capsule42

Labels
auro-hyperlink Type: Feature New Feature
Projects
None yet
Milestone
No milestone
2 participants
@blackfalcon @jason-capsule42