Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy es5 bundling resources #166

Closed
blackfalcon opened this issue May 4, 2023 · 1 comment · Fixed by #170
Closed

Remove legacy es5 bundling resources #166

blackfalcon opened this issue May 4, 2023 · 1 comment · Fixed by #170
Assignees
@irma-kurnia-alaska
Labels
auro-hyperlink released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress
Milestone
Node 18+ update

Comments

@blackfalcon
Copy link
Member

Is your feature request related to a problem? Please describe.

This repo still contains resources related to the bundling of an es5 module, local demo Sass, and still supports legacy concepts like non-rem CSS post-processing.

Describe the solution you'd like

Remove all es5 resources required for bundling. This includes all script references and npm dependencies.

Remove these legacy services. Also, make sure that they are removed from all documentation including the README and API docs.

Update the index.html file in the ./dir to use CDN style resources. The local demo Sass resources should be deleted. The npm script for processing these demo styles should also be released

Please delete any _legacy directory if one exists.

Exit criteria

This issue will be complete once all legacy Sass and es5 building resources have been removed from the repo.

See linked commits for update references.

This issue was copied from #61 by @blackfalcon.

This issue was copied from #56 by @blackfalcon.
@blackfalcon blackfalcon added the Status: Work In Progress Issue or Pull Request work is in Progress label May 4, 2023
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-flight May 4, 2023
@blackfalcon blackfalcon added auro-hyperlink Type: perf and removed Status: Work In Progress Issue or Pull Request work is in Progress labels May 4, 2023
@blackfalcon blackfalcon added this to the Node 18+ support milestone May 4, 2023
@irma-kurnia-alaska irma-kurnia-alaska added the Status: Work In Progress Issue or Pull Request work is in Progress label May 8, 2023
irma-kurnia-alaska pushed a commit that referenced this issue May 8, 2023
@irma-kurnia-phtn
perf(es5): Remove legacy es5 bundling resources #166
5f9f43d 
Changes to be committed:
	modified:   README.md
	deleted:     index.html
@irma-kurnia-alaska irma-kurnia-alaska mentioned this issue May 8, 2023
Merged
3 tasks
blackfalcon pushed a commit that referenced this issue Jun 29, 2023
@irma-kurnia-phtn @blackfalcon
perf(es5): Remove legacy es5 bundling resources #166
8133604 
Changes to be committed:
	modified:   README.md
	deleted:     index.html
blackfalcon pushed a commit that referenced this issue Aug 18, 2023
@irma-kurnia-phtn @blackfalcon
perf(es5): Remove legacy es5 bundling resources #166
34a1a69 
Changes to be committed:
	modified:   README.md
	deleted:     index.html
blackfalcon pushed a commit that referenced this issue Aug 18, 2023
@semantic-release-bot
chore(release): 3.3.4 [skip ci]
7391455 
## [3.3.4](v3.3.3...v3.3.4) (2023-08-18)

### Bug Fixes

* general feedback review ([e8aa95f](e8aa95f))
* re-add docTemplates/ to .gitignore per [#171](#171) ([fcf143a](fcf143a))

### Performance Improvements

* **es5:** Remove legacy es5 bundling resources [#166](#166) ([34a1a69](34a1a69))
* general update to complete update node 18 ([4350122](4350122))
* **node18:** update repo to support Node 18+ [#168](#168) ([8e8b3bb](8e8b3bb))
* remove unused script ([40d2386](40d2386))
* update general dependencies node 18 ([f12886d](f12886d))
* update npm script, remove files ([d7ef58f](d7ef58f))
* update to Lit2.0, TS support, issue templates, component registration extension [#167](#167) ([ca387bc](ca387bc))
@blackfalcon
Copy link
Member Author

🎉 This issue has been resolved in version 3.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irma-kurnia-alaska irma-kurnia-alaska

Labels
auro-hyperlink released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress
Projects
None yet
Milestone
Node 18+ update
Development

Successfully merging a pull request may close this issue.

Irmaku/update node18 AlaskaAirlines/auro-hyperlink
2 participants
@blackfalcon @irma-kurnia-alaska