Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink incorrectly displaying on-dark UI #177

Closed
blackfalcon opened this issue Aug 25, 2023 · 1 comment · Fixed by #212 or #216
Closed

Hyperlink incorrectly displaying on-dark UI #177

blackfalcon opened this issue Aug 25, 2023 · 1 comment · Fixed by #212 or #216
Assignees

Comments

@blackfalcon
Copy link
Member

Please verify the version of auro-hyperlink you have installed

3.3.3

Please describe the bug

Looking at the newly released AS.com header/footer, I noticed that we have issues with the :focus-visible state for auro-hyperlink when on a dark background. Please see the screen recording below.

Aug-25-2023 11-15-42

I understand that we allow for users to change the appearance of the hyperlink using the CSS part of link, but we have an inconsistency issue with the different states of the element.

The biggest issue is the use of the hyperlink in the card UIs. This bug clearly creates a useability issue.

Screen Shot 2023-08-25 at 11 18 41 AM

Reproducing the error

This issue cannot be reproduced on the Auro docsite

Expected behavior

The hyperlink element should represent itself correctly in situations of on-light and on-dark backgrounds. This includes all dates of the element, specifically :focus-visible.

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Additional context

Exit criteria

This issue can be closed once the hyperlink element correctly addresses all UI states as described in the design specification document.

@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes auro-hyperlink not-reviewed Issue has not been reviewed by Auro team members labels Aug 25, 2023
@blackfalcon blackfalcon removed their assignment Aug 25, 2023
@Patrick-Daly-AA
Copy link

Our piece of investigation is to look and see if we're using the right colors. From there, it either goes to the Content team if it was modified for the footer, or to Design if we need to update the design to meet the needs of the footer.

@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Oct 19, 2023
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Nov 1, 2023
@jason-capsule42 jason-capsule42 self-assigned this Jul 16, 2024
@jason-capsule42 jason-capsule42 linked a pull request Jul 16, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 linked a pull request Sep 19, 2024 that will close this issue
6 tasks
@jason-capsule42 jason-capsule42 removed the Type: Bug Bug or Bug fixes label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants