-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move theming support from Beta to Main #216
Conversation
The issue around the misshaped UI was related to the manual nudging of the inserted icon and the updates to the icons shape and relative size over time. Updating the nudge from 2px to 4px addresses the UI issue. This commit also has an update to the README based on updates to the generator with the build process. On branch dsande/focusVisible/209 Changes to be committed: modified: README.md modified: src/style.scss
## [3.6.1-beta.1](v3.6.0...v3.6.1-beta.1) (2024-07-16) ### Bug Fixes * adjust shape of UI for a11y UI 209 ([847630d](847630d))
# [3.7.0-beta.1](v3.6.1-beta.1...v3.7.0-beta.1) (2024-07-19) ### Features * **theme:** update styles to support themeing ([2c89f15](2c89f15))
# [3.7.0-beta.2](v3.7.0-beta.1...v3.7.0-beta.2) (2024-07-20) ### Performance Improvements * use icon element versioning ([0181399](0181399))
|
Reviewer's Guide by SourceryThis pull request implements theming support for the auro-hyperlink component. The changes include adding new CSS custom properties for various states and types of hyperlinks, implementing color variants for different modes (default and inverse), and updating the component to use these new styles. The PR also adds support for ondark variants of existing examples and introduces new files for handling color styles and icon versioning. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Verify that changing 'noopener noreferrer' to 'noOpener noReferrer' doesn't affect security features in browsers.
- Consider adding more strict ESLint rules in the eslint.config.mjs file, which could help maintain code quality across the project.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟡 Complexity: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
# [3.7.0-beta.3](v3.7.0-beta.2...v3.7.0-beta.3) (2024-08-26) ### Performance Improvements * update icon and all other dependencies ([92e2112](92e2112))
# [3.7.0-beta.4](v3.7.0-beta.3...v3.7.0-beta.4) (2024-09-17) ### Performance Improvements * update dependencies ([a52c27c](a52c27c))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to work as expected, I'm not seeing anything jump out at me! The IDE settings file is the only thing I can see 🤷♂️
# [3.7.0-beta.6](v3.7.0-beta.5...v3.7.0-beta.6) (2024-09-18) ### Performance Improvements * point to library scripts for build process ([b091f5b](b091f5b))
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #177, #211
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Move theming support from Beta to Main by introducing CSS variable-based theming for the auro-hyperlink component, adding support for 'ondark' mode, and refactoring for performance improvements. Update documentation and tests to align with these changes.
New Features:
Enhancements:
Documentation:
Tests: