Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move theming support from Beta to Main #216

Merged
merged 23 commits into from
Sep 30, 2024
Merged

Move theming support from Beta to Main #216

merged 23 commits into from
Sep 30, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Aug 14, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #177, #211

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Move theming support from Beta to Main by introducing CSS variable-based theming for the auro-hyperlink component, adding support for 'ondark' mode, and refactoring for performance improvements. Update documentation and tests to align with these changes.

New Features:

  • Introduce theming support for the auro-hyperlink component, allowing customization of styles using CSS variables.

Enhancements:

  • Refactor the auro-hyperlink component to use icon element versioning for improved performance.
  • Update the auro-hyperlink component to support 'ondark' mode, providing better styling options for dark backgrounds.

Documentation:

  • Add documentation examples for the new 'ondark' mode in various use cases of the auro-hyperlink component.

Tests:

  • Update tests to reflect changes in rel attribute values for auro-hyperlink, ensuring compatibility with new theming features.

Sorry, something went wrong.

blackfalcon and others added 8 commits July 15, 2024 20:18

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
The issue around the misshaped UI was related to the manual nudging of
the inserted icon and the updates to the icons shape and relative size
over time.

Updating the nudge from 2px to 4px addresses the UI issue.

This commit also has an update to the README based on updates to the
generator with the build process.

On branch dsande/focusVisible/209
Changes to be committed:
modified:   README.md
modified:   src/style.scss

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
## [3.6.1-beta.1](v3.6.0...v3.6.1-beta.1) (2024-07-16)

### Bug Fixes

* adjust shape of UI for a11y UI 209 ([847630d](847630d))

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
# [3.7.0-beta.1](v3.6.1-beta.1...v3.7.0-beta.1) (2024-07-19)

### Features

* **theme:** update styles to support themeing ([2c89f15](2c89f15))

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
# [3.7.0-beta.2](v3.7.0-beta.1...v3.7.0-beta.2) (2024-07-20)

### Performance Improvements

* use icon element versioning ([0181399](0181399))
@jordanjones243 jordanjones243 self-assigned this Aug 14, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner August 14, 2024 18:21
@CLAassistant
Copy link

CLAassistant commented Aug 14, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ blackfalcon
✅ jordanjones243
✅ jason-capsule42
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

sourcery-ai bot commented Aug 14, 2024

Reviewer's Guide by Sourcery

This pull request implements theming support for the auro-hyperlink component. The changes include adding new CSS custom properties for various states and types of hyperlinks, implementing color variants for different modes (default and inverse), and updating the component to use these new styles. The PR also adds support for ondark variants of existing examples and introduces new files for handling color styles and icon versioning.

File-Level Changes

Files Changes
src/tokens.scss Added new CSS custom properties for various hyperlink states and types
src/color.scss Implemented color variants for different modes (default and inverse) and hyperlink types
src/auro-hyperlink.js
src/style.scss
Updated component to use new theming styles
demo/api.md
demo/index.md
apiExamples/basic-ondark.html
apiExamples/cta-ondark.html
apiExamples/external-ondark.html
apiExamples/external-referrer-ondark.html
apiExamples/navPattern-ondark.html
apiExamples/navStyle-ondark.html
apiExamples/roleButton-ondark.html
Added ondark variants for existing examples
src/iconVersion.js
src/auro-hyperlink.js
Introduced icon versioning support
README.md
docs/partials/index.md
docs/partials/api.md
Updated documentation to reflect new theming capabilities
src/component-base.mjs Refactored some variable names for consistency
eslint.config.mjs Updated ESLint configuration

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@jordanjones243 jordanjones243 linked an issue Aug 14, 2024 that may be closed by this pull request
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Verify that changing 'noopener noreferrer' to 'noOpener noReferrer' doesn't affect security features in browsers.
  • Consider adding more strict ESLint rules in the eslint.config.mjs file, which could help maintain code quality across the project.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟡 Complexity: 2 issues found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

jordanjones243 and others added 7 commits August 26, 2024 15:59

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
# [3.7.0-beta.3](v3.7.0-beta.2...v3.7.0-beta.3) (2024-08-26)

### Performance Improvements

* update icon and all other dependencies ([92e2112](92e2112))
# [3.7.0-beta.4](v3.7.0-beta.3...v3.7.0-beta.4) (2024-09-17)

### Performance Improvements

* update dependencies ([a52c27c](a52c27c))
# [3.7.0-beta.5](v3.7.0-beta.4...v3.7.0-beta.5) (2024-09-17)

### Features

* add component name as attribute [#219](#219) ([c430712](c430712))

### Performance Improvements

* refactor custom component registration config ([87ba85a](87ba85a))
@jordanjones243 jordanjones243 linked an issue Sep 17, 2024 that may be closed by this pull request
Copy link
Contributor

@DukeFerdinand DukeFerdinand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work as expected, I'm not seeing anything jump out at me! The IDE settings file is the only thing I can see 🤷‍♂️

jordanjones243 and others added 3 commits September 18, 2024 12:58
# [3.7.0-beta.6](v3.7.0-beta.5...v3.7.0-beta.6) (2024-09-18)

### Performance Improvements

* point to library scripts for build process ([b091f5b](b091f5b))
@jordanjones243 jordanjones243 linked an issue Sep 19, 2024 that may be closed by this pull request
jordanjones243 and others added 4 commits September 24, 2024 13:39
BREAKING CHANGE: trigger major release for color theme support #211
# [4.0.0-beta.1](v3.7.0-beta.6...v4.0.0-beta.1) (2024-09-24)

### Performance Improvements

* sync package and package-lock ([2964a35](2964a35))
* update dependencies ([675600f](675600f))

### BREAKING CHANGES

* trigger major release for color theme support #211
@jason-capsule42 jason-capsule42 merged commit 6fa3dc7 into main Sep 30, 2024
8 of 9 checks passed
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
6 participants