Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSR Support #193

Closed
blackfalcon opened this issue Jan 10, 2024 · 0 comments · Fixed by #195
Closed

Add SSR Support #193

blackfalcon opened this issue Jan 10, 2024 · 0 comments · Fixed by #195
Assignees

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Jan 10, 2024

Discussed in AlaskaAirlines/WC-Generator#457

Originally posted by blackfalcon January 9, 2024
As of Lit 2.0 it's been understood that LitElement web components will be supported inside common SSR environments. This discussion is for supporting the various updates needed to deliver this capability.

Scope

The scope of this issue is to update the repo with the following criteria

  1. install the auro-library as root dependency
  2. add type="module" to the ./package.json
  3. commitlint.config.js → commitlint.config.cjs
  4. delete the following local scripts
    • . /packageScripts/postinstall.(m)js
    • ./scripts/generateDocs.(m)js
    • ./scripts/postCss.(m)js
    • ./scripts/pre-commit.(m)js
  5. Update the ./package.json "scripts" references
"build:docs": "node ./node_modules/@aurodesignsystem/auro-library/scripts/build/generateDocs.mjs",
"preCommit": "node ./node_modules/@aurodesignsystem/auro-library/scripts/build/pre-commit.mjs",
"postCss:component": "node ./node_modules/@aurodesignsystem/auro-library/scripts/build/postCss.mjs",
"postinstall": "node ./node_modules/@aurodesignsystem/auro-library/scripts/build/postinstall.mjs",

Exit criteria

This issue can be closed once the local files have been deleted, the dependencies and scripts have been updated and the rebuilds successfully off of the auro-library resources.

All local dependencies should be up to date as well.

@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/WC-Generator Jan 10, 2024
@pgm369 pgm369 self-assigned this Jan 13, 2024
@pgm369 pgm369 mentioned this issue Jan 13, 2024
6 tasks
@pgm369 pgm369 linked a pull request Jan 13, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 mentioned this issue Jan 17, 2024
6 tasks
@jordanjones243 jordanjones243 linked a pull request Jan 17, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 self-assigned this Jan 18, 2024
blackfalcon pushed a commit that referenced this issue Jan 20, 2024
# [3.5.0](v3.4.2...v3.5.0) (2024-01-20)

### Features

* **ssr:** add support for SSR projects [#193](#193) ([6eeb233](6eeb233))

### Performance Improvements

* **deps:** update dependencies ([8cacced](8cacced))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants