Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-hyperlink: missing focus styles when inside another shadow root #55

Closed
geoffrich opened this issue Apr 21, 2021 · 3 comments · Fixed by #61
Closed

auro-hyperlink: missing focus styles when inside another shadow root #55

geoffrich opened this issue Apr 21, 2021 · 3 comments · Fixed by #61
Assignees
@geoffrich
Labels
released Completed work has been released Type: Bug Bug or Bug fixes

Comments

@geoffrich
Copy link
Contributor

Describe the bug

When auro-hyperlink is rendered in another shadow root, focus styles do not apply.

Related: AlaskaAirlines/auro-button#97

To Reproduce

Steps to reproduce the behavior:

  1. Create a component that renders auro-hyperlink in the shadow DOM
  2. Attempt to tab to it. Notice that focus styles are not applied

Expected behavior

Focus styles are applied.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox
  • Version: 87

Additional context

Fix should be similar to AlaskaAirlines/auro-button#102
@geoffrich geoffrich added the Type: Bug Bug or Bug fixes label Apr 21, 2021
@blackfalcon
Copy link
Member

This update should be addressed with #39

@blackfalcon blackfalcon removed their assignment Apr 24, 2021
@geoffrich
Copy link
Contributor Author

This was not resolved with the linked PR. Since auro-hyperlink is often embedded in the component hangar components, I think it's worth applying the polyfill the same way auro-button does until we decided on the polyfill support going forward.

Reference: AlaskaAirlines/auro-button#118

geoffrich added a commit that referenced this issue Jun 4, 2021
@geoffrich
feat: apply focus-visible polyfill to shadow root #55
4a62a95
@geoffrich geoffrich mentioned this issue Jun 4, 2021
Merged
3 tasks
blackfalcon pushed a commit that referenced this issue Jun 7, 2021
@geoffrich @blackfalcon
feat: apply focus-visible polyfill to shadow root #55
46cbacb
blackfalcon pushed a commit that referenced this issue Jun 7, 2021
@semantic-release-bot
chore(release): 2.3.0 [skip ci]
f05f19c 
# [2.3.0](v2.2.1...v2.3.0) (2021-06-07)

### Features

* apply focus-visible polyfill to shadow root [#55](#55) ([46cbacb](46cbacb))
@blackfalcon
Copy link
Member

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoffrich geoffrich

Labels
released Completed work has been released Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: apply focus-visible polyfill to shadow root #55 AlaskaAirlines/auro-hyperlink
2 participants
@blackfalcon @geoffrich