Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #242

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Auro Hyperlink to use Node.js v22 and update supporting documentation and workflows.

Build:

  • Update Node.js to v22.

CI:

  • Update CI workflows to test on Node.js v20 and v22.

Documentation:

  • Update documentation to reflect Node.js v22 support and conventional commit guidelines.

Tests:

  • Update test matrix to include Node.js v22.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:42
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This PR updates the Auro project to use Node.js v22 and updates supporting documentation and workflows.

State diagram: PR workflow changes

stateDiagram-v2
    [*] --> IssueSubmitted: Submit Issue
    IssueSubmitted --> TeamConsultation: Consult Auro Team
    TeamConsultation --> Development: Approval Received
    Development --> PullRequest: Submit PR

    state PullRequest {
        [*] --> TestNode20: Run Tests on Node 20
        [*] --> TestNode22: Run Tests on Node 22
        TestNode20 --> Checks
        TestNode22 --> Checks
        Checks --> [*]
    }

    PullRequest --> Review: All Tests Pass
    Review --> [*]: Merged
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated Node.js version to v22
  • Updated related documentation and workflows
.github/CONTRIBUTING.md
.github/settings.yml
.github/workflows/testPublish.yml
package.json
package-lock.json
Updated repository settings
  • Removed repository description
  • Updated repository topics
  • Added team access control
.github/settings.yml
Updated contribution guidelines
  • Clarified contribution process
  • Updated guidance on issue submission
  • Updated guidance on pull request submission
  • Updated guidance on rebasing
  • Added information on conventional commits and commit message format
.github/CONTRIBUTING.md
Updated code of conduct
  • Minor updates to wording and formatting
.github/CODE_OF_CONDUCT.md
Updated issue templates
  • Updated labels and content of issue templates
.github/ISSUE_TEMPLATE/bug_report.yml
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml
Updated stale workflow
  • Added comments for stale and closed issues
.github/stale.yml
Updated pull request template
  • Minor updates to wording and formatting
.github/PULL_REQUEST_TEMPLATE.md
Updated codeql workflow
  • Removed unused queries
.github/workflows/codeql.yml
Added publish demo workflow
  • Added workflow to publish demo on pull request to main branch
.github/workflows/publishDemo.yml
Updated CODEOWNERS file
  • Updated code owners for specific files
.github/CODEOWNERS

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jordanjones243 jordanjones243 merged commit 5a8ba3e into main Dec 20, 2024
6 of 7 checks passed
@jordanjones243 jordanjones243 deleted the migration/package-update/node-v22 branch December 20, 2024 21:34
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
3 participants