Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-icon: customSvg #124

Closed
jason-capsule42 opened this issue Jul 11, 2024 · 0 comments · Fixed by #125, #126 or #130
Closed

auro-icon: customSvg #124

jason-capsule42 opened this issue Jul 11, 2024 · 0 comments · Fixed by #125, #126 or #130
Assignees
Labels

Comments

@jason-capsule42
Copy link
Member

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

Add a new customSvg slot that, when used, supports the user providing their own SVG HTML in the auro-icon slot content rather than relying an a CDN request based on the category and name of the desired icon.

Describe alternatives you've considered

No response

Additional context

This feature was built as a POC and reviewed with Brandon and Jordan for approval before submitting the work.

@jason-capsule42 jason-capsule42 self-assigned this Jul 11, 2024
@jason-capsule42 jason-capsule42 linked a pull request Jul 11, 2024 that will close this issue
8 tasks
blackfalcon pushed a commit that referenced this issue Jul 16, 2024
# [5.0.0-beta.1](v4.3.1...v5.0.0-beta.1) (2024-07-16)

### Bug Fixes

* **label:** add classmap for label attribute ([e0a1ca5](e0a1ca5))

### Features

* add customSvg attribute support [#124](#124) ([105d473](105d473))
* **tokens:** add component level tokens for theming ([a14ed35](a14ed35))

### BREAKING CHANGES

* **tokens:** Advisory variant has been removed. Warning variant is the intended replacement.
@jason-capsule42 jason-capsule42 linked a pull request Jul 18, 2024 that will close this issue
6 tasks
blackfalcon pushed a commit that referenced this issue Jul 18, 2024
# [5.0.0-beta.1](v4.4.0...v5.0.0-beta.1) (2024-07-18)

### Bug Fixes

* **label:** add classmap for label attribute ([9283694](9283694))

### Features

* add customSvg attribute support [#124](#124) ([9fad76f](9fad76f))
* **tokens:** add component level tokens for theming ([11abd42](11abd42))
* **tokens:** add component level tokens for theming ([4f60e99](4f60e99))

### BREAKING CHANGES

* **tokens:** Advisory variant has been removed. Warning variant is the intended replacement.
* **tokens:** Advisory variant has been removed. Warning variant is the intended replacement.
blackfalcon pushed a commit that referenced this issue Jul 18, 2024
# [5.0.0-beta.1](v4.4.0...v5.0.0-beta.1) (2024-07-18)

### Bug Fixes

* **label:** add classmap for label attribute ([9283694](9283694))

### Features

* add customSvg attribute support [#124](#124) ([9fad76f](9fad76f))
* **tokens:** add component level tokens for theming ([11abd42](11abd42))
* **tokens:** add component level tokens for theming ([4f60e99](4f60e99))

### Performance Improvements

* update repo dependencies ([b7dd2d1](b7dd2d1))

### BREAKING CHANGES

* **tokens:** Advisory variant has been removed. Warning variant is the intended replacement.
* **tokens:** Advisory variant has been removed. Warning variant is the intended replacement.
blackfalcon pushed a commit that referenced this issue Jul 18, 2024
# [5.0.0-beta.1](v4.4.0...v5.0.0-beta.1) (2024-07-18)

### Bug Fixes

* **label:** add classmap for label attribute ([9283694](9283694))

### Features

* add customSvg attribute support [#124](#124) ([9fad76f](9fad76f))
* **tokens:** add component level tokens for theming ([11abd42](11abd42))
* **tokens:** add component level tokens for theming ([4f60e99](4f60e99))

### Performance Improvements

* update package dependencies ([54fd107](54fd107))

### BREAKING CHANGES

* **tokens:** Advisory variant has been removed. Warning variant is the intended replacement.
* **tokens:** Advisory variant has been removed. Warning variant is the intended replacement.
blackfalcon pushed a commit that referenced this issue Jul 18, 2024
# [5.0.0-beta.1](v4.4.0...v5.0.0-beta.1) (2024-07-18)

### Bug Fixes

* **label:** add classmap for label attribute ([9283694](9283694))

### Features

* add customSvg attribute support [#124](#124) ([9fad76f](9fad76f))
* **tokens:** add component level tokens for theming ([11abd42](11abd42))
* **tokens:** add component level tokens for theming ([4f60e99](4f60e99))

### Performance Improvements

* update dependencies ([2fd4b67](2fd4b67))
* update package dependencies ([54fd107](54fd107))

### BREAKING CHANGES

* **tokens:** Advisory variant has been removed. Warning variant is the intended replacement.
* **tokens:** Advisory variant has been removed. Warning variant is the intended replacement.
blackfalcon pushed a commit that referenced this issue Jul 18, 2024
This commit address the following updates:

  1. add component level tokens for theming
  2. Advisory variant has been removed. Warning variant is the intended replacement.
  3. add classmap for label attribute
  4. add customSvg attribute support #124

Changes to be committed:
modified:   README.md
new file:   apiExamples/customSvg.html
modified:   apiExamples/onDark.html
modified:   apiExamples/visualState.html
new file:   demo/alaska.html
modified:   demo/alaska.md
modified:   demo/api.md
modified:   docs/api.md
modified:   docs/partials/api.md
modified:   index.js
modified:   package-lock.json
modified:   package.json
modified:   src/auro-icon.js
modified:   src/baseIcon.js
new file:   src/color.scss
deleted:    src/iconStyle.scss
modified:   src/style.scss
new file:   src/tokens.scss
modified:   test/auro-icon.test.js
blackfalcon pushed a commit that referenced this issue Jul 18, 2024
This commit address the following updates:

  1. add component level tokens for theming
  2. Advisory variant has been removed. Warning variant is the intended replacement.
  3. add classmap for label attribute
  4. add customSvg attribute support #124

Changes to be committed:
modified:   README.md
new file:   apiExamples/customSvg.html
modified:   apiExamples/onDark.html
modified:   apiExamples/visualState.html
new file:   demo/alaska.html
modified:   demo/alaska.md
modified:   demo/api.md
modified:   docs/api.md
modified:   docs/partials/api.md
modified:   index.js
modified:   package-lock.json
modified:   package.json
modified:   src/auro-icon.js
modified:   src/baseIcon.js
new file:   src/color.scss
deleted:    src/iconStyle.scss
modified:   src/style.scss
new file:   src/tokens.scss
modified:   test/auro-icon.test.js
blackfalcon pushed a commit that referenced this issue Jul 19, 2024
# [4.5.0-beta.1](v4.4.0...v4.5.0-beta.1) (2024-07-19)

### Features

* update to support component theming ([c6fcdb3](c6fcdb3)), closes [#124](#124)
@jason-capsule42 jason-capsule42 linked a pull request Aug 20, 2024 that will close this issue
6 tasks
jason-capsule42 added a commit that referenced this issue Aug 20, 2024
This commit address the following updates:

  1. add component level tokens for theming
  2. Advisory variant has been removed. Warning variant is the intended replacement.
  3. add classmap for label attribute
  4. add customSvg attribute support #124

Changes to be committed:
modified:   README.md
new file:   apiExamples/customSvg.html
modified:   apiExamples/onDark.html
modified:   apiExamples/visualState.html
new file:   demo/alaska.html
modified:   demo/alaska.md
modified:   demo/api.md
modified:   docs/api.md
modified:   docs/partials/api.md
modified:   index.js
modified:   package-lock.json
modified:   package.json
modified:   src/auro-icon.js
modified:   src/baseIcon.js
new file:   src/color.scss
deleted:    src/iconStyle.scss
modified:   src/style.scss
new file:   src/tokens.scss
modified:   test/auro-icon.test.js
jason-capsule42 pushed a commit that referenced this issue Aug 20, 2024
# [4.5.0-beta.1](v4.4.0...v4.5.0-beta.1) (2024-07-19)

### Features

* update to support component theming ([c6fcdb3](c6fcdb3)), closes [#124](#124)
blackfalcon pushed a commit that referenced this issue Aug 20, 2024
# [4.5.0](v4.4.0...v4.5.0) (2024-08-20)

### Features

* update to support component theming ([b101b5d](b101b5d)), closes [#124](#124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment