-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AURO MIGRATION: Update node to v22 #163
Conversation
Reviewer's Guide by SourceryThis PR updates the Node.js version used in the project to v22. The changes include updates to the CI workflow files, settings files, and package files to reflect the new version. The update ensures that the project uses a supported Node.js version and benefits from the latest features and performance improvements. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -17,7 +17,7 @@ | |||
"main": "index.js", | |||
"license": "Apache-2.0", | |||
"engines": { | |||
"node": "^18.x || ^20.x" | |||
"node": "^20.x || ^22.x " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Remove trailing space after ^22.x
The trailing space in the engines field could potentially cause issues with some package managers or tooling that strictly parse semver ranges.
"node": "^20.x || ^22.x " | |
"node": "^20.x || ^22.x" |
🎉 This PR is included in version 6.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves AlaskaAirlines/auro-templates#6
Summary by Sourcery
Update Node.js to version 22.
Enhancements:
CI: