Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #296

Closed
2 tasks
jordanjones243 opened this issue Mar 13, 2024 · 3 comments · Fixed by #317, #321, #324, #335 or #338
Closed
2 tasks

Update color tokens for theming support #296

jordanjones243 opened this issue Mar 13, 2024 · 3 comments · Fixed by #317, #321, #324, #335 or #338
Assignees

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 13, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243 jordanjones243 added Type: Feature New Feature auro-input not-reviewed Issue has not been reviewed by Auro team members labels Mar 13, 2024
@jordanjones243
Copy link
Contributor Author

jordanjones243 commented Mar 13, 2024

  • Hardcoded
    • Transparent
    • Disabled background: none
  • Tier 1
    • Bordered wrapper background color: var(--ds-color-base-white, $ds-color-base-white);

@jordanjones243 jordanjones243 linked a pull request Mar 15, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 removed the not-reviewed Issue has not been reviewed by Auro team members label May 29, 2024
@jordanjones243 jordanjones243 linked a pull request May 30, 2024 that will close this issue
19 tasks
blackfalcon pushed a commit that referenced this issue Jun 24, 2024
# [3.1.0-beta.1](v3.0.1...v3.1.0-beta.1) (2024-06-24)

### Features

* refactor color token structure with tier 3 tokens [#296](#296) ([5653863](5653863))

### Performance Improvements

* **icon:** update to use beta of auro-icon with theme support ([7df7568](7df7568))
* replace hardcoded styles with tokens ([e9700ee](e9700ee))
jason-capsule42 pushed a commit that referenced this issue Jul 4, 2024
# [3.1.0-beta.1](v3.0.1...v3.1.0-beta.1) (2024-06-24)

### Features

* refactor color token structure with tier 3 tokens [#296](#296) ([5653863](5653863))

### Performance Improvements

* **icon:** update to use beta of auro-icon with theme support ([7df7568](7df7568))
* replace hardcoded styles with tokens ([e9700ee](e9700ee))
@jason-capsule42 jason-capsule42 linked a pull request Jul 4, 2024 that will close this issue
6 tasks
blackfalcon pushed a commit that referenced this issue Jul 4, 2024
# [3.1.0](v3.0.1...v3.1.0) (2024-07-04)

### Features

* refactor color token structure with tier 3 tokens [#296](#296) ([f15238b](f15238b))

### Performance Improvements

* **button:** use new auro-button flat variant for clear and show password ([aa46aba](aa46aba))
* **deps:** update to latest button beta version ([7be71f6](7be71f6))
* **deps:** use updated dependency versions ([c5a9fe6](c5a9fe6))
* **icon:** update to use beta of auro-icon with theme support ([9a5cfae](9a5cfae))
* replace hardcoded styles with tokens ([a7ef751](a7ef751))
@jordanjones243 jordanjones243 linked a pull request Sep 13, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 removed a link to a pull request Sep 13, 2024
6 tasks
@jordanjones243
Copy link
Contributor Author

Ticket is blocked until auro-button's theming support changes are complete.

@jordanjones243 jordanjones243 mentioned this issue Sep 18, 2024
6 tasks
@jordanjones243
Copy link
Contributor Author

Need design to revise the semantic tokens being used within the tokens.scss file.

jordanjones243 added a commit that referenced this issue Sep 25, 2024
BREAKING CHANGE: trigger major release for color theming support #296
@jordanjones243 jordanjones243 linked a pull request Sep 25, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 mentioned this issue Sep 25, 2024
6 tasks
jordanjones243 added a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for color theming support #296
jordanjones243 added a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for color theming support #296
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
jordanjones243 added a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for color theming support #296
jordanjones243 pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
jordanjones243 pushed a commit that referenced this issue Sep 30, 2024
* refactor color token structure with tier 3 tokens [#296](#296) ([f15238b](f15238b))

* **button:** use new auro-button flat variant for clear and show password ([aa46aba](aa46aba))
* **deps:** update to latest button beta version ([7be71f6](7be71f6))
* **deps:** use updated dependency versions ([c5a9fe6](c5a9fe6))
* **icon:** update to use beta of auro-icon with theme support ([9a5cfae](9a5cfae))
* replace hardcoded styles with tokens ([a7ef751](a7ef751))
jordanjones243 added a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for color theming support #296
jordanjones243 pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
jordanjones243 pushed a commit that referenced this issue Sep 30, 2024
* refactor color token structure with tier 3 tokens [#296](#296) ([f15238b](f15238b))

* **button:** use new auro-button flat variant for clear and show password ([aa46aba](aa46aba))
* **deps:** update to latest button beta version ([7be71f6](7be71f6))
* **deps:** use updated dependency versions ([c5a9fe6](c5a9fe6))
* **icon:** update to use beta of auro-icon with theme support ([9a5cfae](9a5cfae))
* replace hardcoded styles with tokens ([a7ef751](a7ef751))
jordanjones243 added a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for color theming support #296
jordanjones243 pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0-beta.2](v4.0.0-beta.1...v4.0.0-beta.2) (2024-09-30)

### Bug Fixes

* remove private default of attribute ([dbeb3df](dbeb3df))

### Performance Improvements

* **deps:** update to latest beta dependencies ([4747ab2](4747ab2))
* **deps:** update to latest button beta version ([cd30e78](cd30e78))
* **deps:** update to use current dependency versions ([2d49601](2d49601))
* **deps:** use updated dependency versions ([0f7db80](0f7db80))
* update dependencies ([ba59893](ba59893))

### BREAKING CHANGES

* trigger major release for color theming support #296
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for color theming support #296
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0](v3.0.1...v4.0.0) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([bc39bcc](bc39bcc))
* realign text and icons on non-bordered inputs [#333](#333) ([82006bc](82006bc))
* remove private default of attribute ([3195d96](3195d96))
* resolve color theming issues ([65553a0](65553a0))
* **theming:** resolve minor theming issues [#296](#296) ([7802302](7802302))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([f280e8f](f280e8f))
* refactor color token structure with tier 3 tokens [#296](#296) ([5653863](5653863))

### Performance Improvements

* **button:** use new auro-button flat variant for clear and show password ([2a671d2](2a671d2))
* **deps:** update to latest beta dependencies ([42ecf61](42ecf61))
* **icon:** update to use beta of auro-icon with theme support ([7df7568](7df7568))
* refactor custom component registration config ([89a5f20](89a5f20))
* replace hardcoded styles with tokens ([e9700ee](e9700ee))
* update dependencies ([7645408](7645408))

### BREAKING CHANGES

* trigger major release for color theming support #296
@jason-capsule42 jason-capsule42 linked a pull request Sep 30, 2024 that will close this issue
6 tasks
@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment