-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): writeDepVersionFile
method will write the version of root
#71
Conversation
Reviewer's Guide by SourceryThis pull request modifies the Sequence diagram for writeDepVersionFile function with 'root' packagesequenceDiagram
participant Caller
participant versionWriter as versionWriter.js
participant fs as File System
Caller->>versionWriter: call writeDepVersionFile('root')
versionWriter->>fs: require('path').relative(__dirname, './package.json')
versionWriter->>fs: read package.json
fs-->>versionWriter: return version
versionWriter->>fs: write ./src/rootVersion.js
fs-->>versionWriter: confirm write
versionWriter-->>Caller: complete
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a more explicit method (e.g., a boolean flag or enum) to differentiate between root and non-root packages instead of string comparison. This could improve code clarity and reduce potential errors.
- It would be helpful to include more context in the PR description about why this PR needs to be merged before the linked issue. This information can assist reviewers and future maintainers in understanding the dependencies between changes.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
`writeDepVersionFile('root')` will read the version from `./package.json` and write `rootVersion.js` file
4b1d16f
to
eeecbed
Compare
Alaska Airlines Pull Request
writeDepVersionFile('root')
will read the version from./package.json
and writerootVersion.js
fileThis PR should be merged before AlaskaAirlines/auro-datepicker#265
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
New Features:
writeDepVersionFile
method to read the version from the rootpackage.json
and write it to arootVersion.js
file.