-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reference consuming component's package.json, rather than relatively #73
Conversation
Reviewer's Guide by SourceryThis pull request fixes an issue with the Sequence diagram for postInstall.mjs script executionsequenceDiagram
participant A as Consuming Component
participant B as postInstall.mjs
participant C as package.json
A->>B: Execute postInstall.mjs
B->>B: Resolve path to package.json
B->>C: Access consuming component's package.json
C-->>B: Return package.json data
B-->>A: Complete script execution
Class diagram for postInstall.mjs script changesclassDiagram
class postInstall {
+chalk
+createRequire(import.meta.url)
+resolve
+pjson
}
note for postInstall "pjson now references the consuming component's package.json using resolve(process.cwd(), 'package.json')"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chrisfalaska - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 2.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
When using
postInstall.mjs
as part ofauro-library
, the script attempts to reference a relativepackage.json
:If a component such as
auro-input
is referencingpostInatll.mjs
fromauro-library
, the install fails since it cannot find a relativepackage.json
insideauro-library
node_modules
:The
postInstall
script should run fromnode_modules
and reference the consuming component'spackage.json
Alaska Airlines Pull Request
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Bug Fixes: