-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor use of oneworld
attribute
#49
Conversation
Reviewer's Guide by SourceryThis pull request refactors the Class diagram showing changes to AuroLockup componentclassDiagram
class AuroLockup {
+String path
+Boolean standard
-Boolean oneworld (deprecated)
+String variant
+constructor()
+updated()
-generateIconHtml(svgContent)
+render()
}
note for AuroLockup "oneworld attribute deprecated
replaced by variant attribute"
State diagram showing oneworld attribute migrationstateDiagram-v2
[*] --> CheckAttribute
CheckAttribute --> UseOneworld: oneworld attribute used
CheckAttribute --> UseVariant: variant attribute used
UseOneworld --> SetVariant: internally sets
variant='oneworld'
UseVariant --> RenderLockup
SetVariant --> RenderLockup
RenderLockup --> [*]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The removal of the accessibility color information table appears unrelated to the oneworld attribute refactoring. Consider moving this change to a separate PR to maintain clear change scope.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
d625e42
to
2868e1c
Compare
2868e1c
to
6f59be9
Compare
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #44, #48
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Introduce the
variant
attribute to theauro-lockup
component to specify the lockup variant. Deprecate theoneworld
attribute in favor ofvariant="oneworld"
.New Features:
variant
attribute to support different lockup variants.Tests:
variant
attribute.