Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #198

Closed
2 tasks
jordanjones243 opened this issue Mar 13, 2024 · 1 comment · Fixed by #205, #213 or #215
Closed
2 tasks

Update color tokens for theming support #198

jordanjones243 opened this issue Mar 13, 2024 · 1 comment · Fixed by #205, #213 or #215
Assignees

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 13, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243 jordanjones243 added Type: Feature New Feature auro-menu not-reviewed Issue has not been reviewed by Auro team members labels Mar 13, 2024
@jordanjones243
Copy link
Contributor Author

  • Hardcoded
    • Transparent
  • Tier 1
    • Selected and not disabled menu option color: var(--ds-color-base-white, $ds-color-base-white);
    • SVG fill color: var(--ds-color-base-white, $ds-color-base-white);

@jordanjones243 jordanjones243 linked a pull request Jun 4, 2024 that will close this issue
9 tasks
blackfalcon pushed a commit that referenced this issue Jun 24, 2024
# [3.12.0-beta.1](v3.11.4...v3.12.0-beta.1) (2024-06-24)

### Features

* refactor color tokens to use tier 3 tokens [#198](#198) ([9100c1d](9100c1d))
jordanjones243 pushed a commit that referenced this issue Aug 21, 2024
* refactor color tokens to use tier 3 tokens [#198](#198) ([9100c1d](9100c1d))
jordanjones243 pushed a commit that referenced this issue Aug 26, 2024
* refactor color tokens to use tier 3 tokens [#198](#198) ([9100c1d](9100c1d))
@jordanjones243 jordanjones243 linked a pull request Aug 26, 2024 that will close this issue
6 tasks
jordanjones243 added a commit that referenced this issue Sep 24, 2024
BREAKING CHANGE: trigger major release for color theme support #198
@jason-capsule42 jason-capsule42 removed the not-reviewed Issue has not been reviewed by Auro team members label Sep 30, 2024
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
* refactor color tokens to use tier 3 tokens [#198](#198) ([9100c1d](9100c1d))
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for color theme support #198
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0-beta.1](v3.12.0-beta.2...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* **imports:** update all imports to include extension in file path [#208](#208) ([6c973cb](6c973cb))

### Features

* add component name as attribute during custom registration ([72eab39](72eab39))
* refactor color tokens to use tier 3 tokens [#198](#198) ([78f1435](78f1435))

### Performance Improvements

* **deps:** update to correct icon version ([973ddea](973ddea))
* **icon:** use auro-icon for selected check mark ([7326c17](7326c17))
* **icon:** use auro-icon for selected check mark ([cd086de](cd086de))
* refactor custom registration config ([78c786f](78c786f))
* update dependencies ([e61aa0e](e61aa0e))
* update dependencies and address lint issues ([dc36821](dc36821))
* update dependencies and use library scripts ([8c94769](8c94769))

### Reverts

* Revert "perf(icon): use auro-icon for selected check mark" ([9b426da](9b426da))

### BREAKING CHANGES

* trigger major release for color theme support #198
@jordanjones243 jordanjones243 linked a pull request Oct 1, 2024 that will close this issue
6 tasks
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
* refactor color tokens to use tier 3 tokens [#198](#198) ([9100c1d](9100c1d))
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
* refactor color tokens to use tier 3 tokens [#198](#198) ([9100c1d](9100c1d))
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
BREAKING CHANGE: trigger major release for color theme support #198
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
# [4.0.0-beta.1](v3.12.0-beta.2...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* **imports:** update all imports to include extension in file path [#208](#208) ([6c973cb](6c973cb))

### Features

* add component name as attribute during custom registration ([72eab39](72eab39))
* refactor color tokens to use tier 3 tokens [#198](#198) ([78f1435](78f1435))

### Performance Improvements

* **deps:** update to correct icon version ([973ddea](973ddea))
* **icon:** use auro-icon for selected check mark ([7326c17](7326c17))
* **icon:** use auro-icon for selected check mark ([cd086de](cd086de))
* refactor custom registration config ([78c786f](78c786f))
* update dependencies ([e61aa0e](e61aa0e))
* update dependencies and address lint issues ([dc36821](dc36821))
* update dependencies and use library scripts ([8c94769](8c94769))

### Reverts

* Revert "perf(icon): use auro-icon for selected check mark" ([9b426da](9b426da))

### BREAKING CHANGES

* trigger major release for color theme support #198
blackfalcon pushed a commit that referenced this issue Oct 1, 2024
# [4.0.0-beta.1](v3.11.9...v4.0.0-beta.1) (2024-10-01)

### Bug Fixes

* **imports:** update all imports to include extension in file path [#208](#208) ([7d3701a](7d3701a))
* **token:** update token name for container colors ([54a6aaf](54a6aaf))

### Features

* add component name as attribute during custom registration ([e9b22f9](e9b22f9))
* refactor color tokens to use tier 3 tokens [#198](#198) ([4553652](4553652))
* refactor color tokens to use tier 3 tokens [#198](#198) ([b26f06c](b26f06c))

### Performance Improvements

* **deps:** update to correct icon version ([5311cff](5311cff))
* **icon:** use auro-icon for selected check mark ([40ea982](40ea982))
* **icon:** use auro-icon for selected check mark ([8df2bc7](8df2bc7))
* refactor custom registration config ([7e12f20](7e12f20))
* remove label colors from github settings ([d3c2664](d3c2664))
* update dependencies ([025ca7a](025ca7a))
* update dependencies and address lint issues ([a3118b7](a3118b7))
* update dependencies and use library scripts ([009a89c](009a89c))
* update dependencies and use library scripts ([5cb5953](5cb5953))

### Reverts

* Revert "perf(icon): use auro-icon for selected check mark" ([c2b80b3](c2b80b3))

### BREAKING CHANGES

* force major release for theme support
* trigger major release for color theme support #198
blackfalcon pushed a commit that referenced this issue Oct 1, 2024
# [4.0.0-beta.1](v3.11.9...v4.0.0-beta.1) (2024-10-01)

### Bug Fixes

* **imports:** update all imports to include extension in file path [#208](#208) ([7d3701a](7d3701a))
* **token:** update token name for container colors ([54a6aaf](54a6aaf))

### Features

* add component name as attribute during custom registration ([e9b22f9](e9b22f9))
* refactor color tokens to use tier 3 tokens [#198](#198) ([4553652](4553652))
* refactor color tokens to use tier 3 tokens [#198](#198) ([b26f06c](b26f06c))

### Performance Improvements

* **deps:** update to correct icon version ([5311cff](5311cff))
* **icon:** use auro-icon for selected check mark ([40ea982](40ea982))
* **icon:** use auro-icon for selected check mark ([8df2bc7](8df2bc7))
* refactor custom registration config ([7e12f20](7e12f20))
* remove label colors from github settings ([d3c2664](d3c2664))
* update dependencies ([025ca7a](025ca7a))
* update dependencies and address lint issues ([a3118b7](a3118b7))
* update dependencies and use library scripts ([009a89c](009a89c))
* update dependencies and use library scripts ([5cb5953](5cb5953))

### Reverts

* Revert "perf(icon): use auro-icon for selected check mark" ([c2b80b3](c2b80b3))

### BREAKING CHANGES

* force major release for theme support
* trigger major release for color theme support #198
jordanjones243 added a commit that referenced this issue Oct 1, 2024
BREAKING CHANGE: trigger major release for color theme support #198
@jordanjones243 jordanjones243 mentioned this issue Oct 1, 2024
6 tasks
@jordanjones243 jordanjones243 linked a pull request Oct 1, 2024 that will close this issue
6 tasks
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
* refactor color tokens to use tier 3 tokens [#198](#198) ([9100c1d](9100c1d))
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
* refactor color tokens to use tier 3 tokens [#198](#198) ([9100c1d](9100c1d))
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
BREAKING CHANGE: trigger major release for color theme support #198
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
# [4.0.0-beta.1](v3.12.0-beta.2...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* **imports:** update all imports to include extension in file path [#208](#208) ([6c973cb](6c973cb))

### Features

* add component name as attribute during custom registration ([72eab39](72eab39))
* refactor color tokens to use tier 3 tokens [#198](#198) ([78f1435](78f1435))

### Performance Improvements

* **deps:** update to correct icon version ([973ddea](973ddea))
* **icon:** use auro-icon for selected check mark ([7326c17](7326c17))
* **icon:** use auro-icon for selected check mark ([cd086de](cd086de))
* refactor custom registration config ([78c786f](78c786f))
* update dependencies ([e61aa0e](e61aa0e))
* update dependencies and address lint issues ([dc36821](dc36821))
* update dependencies and use library scripts ([8c94769](8c94769))

### Reverts

* Revert "perf(icon): use auro-icon for selected check mark" ([9b426da](9b426da))

### BREAKING CHANGES

* trigger major release for color theme support #198
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
# [4.0.0-beta.1](v3.11.9...v4.0.0-beta.1) (2024-10-01)

### Bug Fixes

* **imports:** update all imports to include extension in file path [#208](#208) ([7d3701a](7d3701a))
* **token:** update token name for container colors ([54a6aaf](54a6aaf))

### Features

* add component name as attribute during custom registration ([e9b22f9](e9b22f9))
* refactor color tokens to use tier 3 tokens [#198](#198) ([4553652](4553652))
* refactor color tokens to use tier 3 tokens [#198](#198) ([b26f06c](b26f06c))

### Performance Improvements

* **deps:** update to correct icon version ([5311cff](5311cff))
* **icon:** use auro-icon for selected check mark ([40ea982](40ea982))
* **icon:** use auro-icon for selected check mark ([8df2bc7](8df2bc7))
* refactor custom registration config ([7e12f20](7e12f20))
* remove label colors from github settings ([d3c2664](d3c2664))
* update dependencies ([025ca7a](025ca7a))
* update dependencies and address lint issues ([a3118b7](a3118b7))
* update dependencies and use library scripts ([009a89c](009a89c))
* update dependencies and use library scripts ([5cb5953](5cb5953))

### Reverts

* Revert "perf(icon): use auro-icon for selected check mark" ([c2b80b3](c2b80b3))

### BREAKING CHANGES

* force major release for theme support
* trigger major release for color theme support #198
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
# [4.0.0-beta.1](v3.11.9...v4.0.0-beta.1) (2024-10-01)

### Bug Fixes

* **imports:** update all imports to include extension in file path [#208](#208) ([7d3701a](7d3701a))
* **token:** update token name for container colors ([54a6aaf](54a6aaf))

### Features

* add component name as attribute during custom registration ([e9b22f9](e9b22f9))
* refactor color tokens to use tier 3 tokens [#198](#198) ([4553652](4553652))
* refactor color tokens to use tier 3 tokens [#198](#198) ([b26f06c](b26f06c))

### Performance Improvements

* **deps:** update to correct icon version ([5311cff](5311cff))
* **icon:** use auro-icon for selected check mark ([40ea982](40ea982))
* **icon:** use auro-icon for selected check mark ([8df2bc7](8df2bc7))
* refactor custom registration config ([7e12f20](7e12f20))
* remove label colors from github settings ([d3c2664](d3c2664))
* update dependencies ([025ca7a](025ca7a))
* update dependencies and address lint issues ([a3118b7](a3118b7))
* update dependencies and use library scripts ([009a89c](009a89c))
* update dependencies and use library scripts ([5cb5953](5cb5953))

### Reverts

* Revert "perf(icon): use auro-icon for selected check mark" ([c2b80b3](c2b80b3))

### BREAKING CHANGES

* force major release for theme support
* trigger major release for color theme support #198
jason-capsule42 pushed a commit that referenced this issue Oct 1, 2024
BREAKING CHANGE: trigger major release for color theme support #198
blackfalcon pushed a commit that referenced this issue Oct 1, 2024
# [4.0.0](v3.11.9...v4.0.0) (2024-10-01)

### Bug Fixes

* **imports:** update all imports to include extension in file path [#208](#208) ([b8c2507](b8c2507))
* **token:** update token name for container colors ([f6d072e](f6d072e))

### Features

* add component name as attribute during custom registration ([af8bb94](af8bb94))
* refactor color tokens to use tier 3 tokens [#198](#198) ([1711058](1711058))
* refactor color tokens to use tier 3 tokens [#198](#198) ([f98820c](f98820c))

### Performance Improvements

* **deps:** update to correct icon version ([2cd1f4e](2cd1f4e))
* **icon:** use auro-icon for selected check mark ([9304084](9304084))
* **icon:** use auro-icon for selected check mark ([c90916b](c90916b))
* refactor custom registration config ([af78b41](af78b41))
* remove label colors from github settings ([81ff3b9](81ff3b9))
* update dependencies ([7483ccc](7483ccc))
* update dependencies ([c1254bf](c1254bf))
* update dependencies and address lint issues ([d841f93](d841f93))
* update dependencies and use library scripts ([a0ec762](a0ec762))
* update dependencies and use library scripts ([5bbcb89](5bbcb89))

### Reverts

* Revert "perf(icon): use auro-icon for selected check mark" ([bbcde9b](bbcde9b))

### BREAKING CHANGES

* trigger major release for color theme support #198
* force major release for theme support
* trigger major release for color theme support #198
@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment