Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to Auro Design System #23

Closed
21 of 27 tasks
Tracked by #22
blackfalcon opened this issue Sep 13, 2021 · 5 comments · Fixed by #73
Closed
21 of 27 tasks
Tracked by #22

Publish to Auro Design System #23

blackfalcon opened this issue Sep 13, 2021 · 5 comments · Fixed by #73
Assignees
Labels
auro-menu Status: Work In Progress Issue or Pull Request work is in Progress

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Sep 13, 2021

Publish Component

Specific steps required to publish this component.

All of the steps outlined below must be completed.

Design & Planning

Development

Documentation

  • Update markdown demo #40
  • Examples and use case info
  • Bundled version info
  • README doc completed with all relative information
  • API documentation created

Testing

  • Browser compatibility - desktop and mobile versions
    • Chrome
    • Firefox
    • Edge (79 +)
    • Safari
  • Accessibility - One or more of the following
    • Axe / Google Lighthouse (baseline standard)
    • Screenreader (determine usability of experience via screenreader)
    • Keyboard use (a user must be able to navigate to key parts via a keyboard)
    • Accessibility should be verified against all browsers
  • Bundled versions tested

Review

Up until the review phase ensuring compliance with the above checklist is the responsibility of the component contributor. Once Design & Planning, Development, Documentation and Testing have been completed you will need a final review phase completed, particularly the Auro Design System team. The final review will verify that all requirements above have indeed been achieved.

When the component is ready for a final review with your designer and the Auro Design System team it is the responsibility of the contributor to coordinate the following reviews:

  • Review demo with the designer
  • Review demo with Auro Team
  • All work is reviewed by Auro team
@blackfalcon blackfalcon added this to the v.2.0-rc milestone Sep 13, 2021
@blackfalcon blackfalcon self-assigned this Sep 13, 2021
@braven112 braven112 mentioned this issue Nov 2, 2021
11 tasks
@blackfalcon blackfalcon removed the Issue label Dec 14, 2021
@blackfalcon blackfalcon modified the milestones: v.2.0-rc, v3.0-rc Dec 15, 2021
@blackfalcon blackfalcon added Status: Work In Progress Issue or Pull Request work is in Progress and removed auroLabs labels Dec 15, 2021
@blackfalcon
Copy link
Member Author

This isn't necessarily blocked or waiting on feedback, but more so this will be ongoing for a bit while we evaluate the code and plan appropriate refactoring in preparation for official release.

@blackfalcon blackfalcon linked a pull request Jan 21, 2022 that will close this issue
6 tasks
@blackfalcon
Copy link
Member Author

@leeejune can you do a design review of https://alaskaairlines-auro-menu-pr-73.surge.sh/

@blackfalcon blackfalcon assigned leeejune and unassigned blackfalcon Jan 21, 2022
@leeejune
Copy link
Contributor

Screen Shot 2022-01-21 at 2 30 22 PM

  • Icon color should be "auro-color-icon-primary-on-light"
  • There should be 12px padding on the left of the icon
  • Divider should be "auro-color-border-divider-on-light"

Question:
Screen Shot 2022-01-21 at 2 28 35 PM
Should this pre selected option be in the same blue selected state?

@blackfalcon
Copy link
Member Author

@leeejune demo URL updated

@leeejune
Copy link
Contributor

@blackfalcon Looks good! Design review done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-menu Status: Work In Progress Issue or Pull Request work is in Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants