New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete code and API review by dev team lead #52

Closed

blackfalcon opened this issue Jan 11, 2022 · 1 comment · Fixed by #58

Assignees

Labels

Milestone

auro-menu v3.0-rc

Member

blackfalcon commented Jan 11, 2022

General Support Request

The scope of this issue is to address areas of refactoring, review, and things like typo corrections.

Support request

Review all submitted code and address areas where there are inconsistencies with the API, address how features are implemented, and apply corrections/refactoring that is appropriately needed for release.

blackfalcon added Type: Refactoring auro-menu labels

blackfalcon self-assigned this

braven112 added this to the auro-menu v3.0-rc milestone

This was referenced Jan 11, 2022

Publish to Auro Design System #23

Closed

Addresses all design and UX as proposed in the design comp #54

Closed

Member Author

blackfalcon commented Jan 11, 2022 •

edited

Loading

isHidden I am pretty sure is not needed. The hide/show event would be managed via a parent element, e.g. auro-dropdown.
indexSelectedOption uses 0 as the lowest number to pre-select a menu item. This should start at 1. The API for this feature is to be reviewed.
listOfOptions is not needed. The auro-menu.js file has a single slot. Having to add a name attribute for every use is unnecessary.
The use of checkmark as an attribute is inconsistent with the Auro API guidelines.
The entire sub-menu feature is incorrect

blackfalcon added a commit that referenced this issue


          refactor(styles): address naming conventions to style files #52

bdf9036

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
modified:   src/auro-sub-menu.js
renamed:    src/style-fixed.scss -> src/style-base-fixed.scss
renamed:    src/style.scss -> src/style-base.scss
renamed:    src/auro-menu-option-fixed.scss -> src/style-menu-option-fixed.scss
renamed:    src/auro-menu-option.scss -> src/style-menu-option.scss
renamed:    src/auro-sub-menu-fixed.scss -> src/style-sub-menu-fixed.scss
renamed:    src/auro-sub-menu.scss -> src/style-sub-menu.scss

blackfalcon mentioned this issue

Refactor in prep for release #58

Merged

6 tasks

blackfalcon added a commit that referenced this issue


          refactor(styles): address naming conventions to style files #52

cd3e934

There are a lot of files in the ./src directory, this commit updates
the names of those files to make it more clear as to what files they are
and what they are used for.

style.scss was renamed to style-base.scss as a simple fix to a
postCss problem.

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
modified:   src/auro-sub-menu.js
renamed:    src/style-fixed.scss -> src/style-base-fixed.scss
renamed:    src/style.scss -> src/style-base.scss
renamed:    src/auro-menu-option-fixed.scss -> src/style-menu-option-fixed.scss
renamed:    src/auro-menu-option.scss -> src/style-menu-option.scss
renamed:    src/auro-sub-menu-fixed.scss -> src/style-sub-menu-fixed.scss
renamed:    src/auro-sub-menu.scss -> src/style-sub-menu.scss

blackfalcon added a commit that referenced this issue


          refactor(isHudden): remove attribute #52

f158c7e

Changes to be committed:
modified:   demo/demo.md
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js

blackfalcon added a commit that referenced this issue


          refactor(isHidden): remove attribute #52

983cfbb

Changes to be committed:
modified:   demo/demo.md
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js

blackfalcon added a commit that referenced this issue


          refactor(listOfOptions): remove unnecessary slot name convention #52

Changes to be committed:
modified:   demo/demo.md
modified:   src/auro-menu.js
modified:   test/auro-menu.test.js

blackfalcon added a commit that referenced this issue


          refactor(listOfOptions): remove unnecessary slot name convention #52

f4d03f4

Changes to be committed:
modified:   demo/demo.md
modified:   src/auro-menu.js
modified:   test/auro-menu.test.js

blackfalcon added a commit that referenced this issue


          refactor(style): simplify checkmark ui #52

6aa51b8

Changes to be committed:
modified:   demo/demo.md
modified:   src/auro-menu-option.js
modified:   src/style-base.scss
modified:   src/style-menu-option.scss

blackfalcon added a commit that referenced this issue


          refactor(style): simplify checkmark ui #52

a848e33

Changes to be committed:
modified:   demo/demo.md
modified:   src/auro-menu-option.js
modified:   src/style-base.scss
modified:   src/style-menu-option.scss

blackfalcon added a commit that referenced this issue


          refactor(style): simplify checkmark ui #52

6b430b4

Changes to be committed:
modified:   demo/demo.md
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
modified:   src/style-base.scss
modified:   src/style-menu-option.scss
modified:   src/style-sub-menu.scss

blackfalcon added a commit that referenced this issue


          refactor(style): simplify checkmark ui #52

fb864c8

Changes to be committed:
modified:   demo/demo.md
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
modified:   src/style-base.scss
modified:   src/style-menu-option.scss
modified:   src/style-sub-menu.scss

blackfalcon linked a pull request

that will close this issue

Refactor in prep for release #58

Merged

6 tasks

blackfalcon added the Status: Review Needed label

blackfalcon added a commit that referenced this issue


          refactor(styles): address naming conventions to style files #52

851ac2a

There are a lot of files in the ./src directory, this commit updates
the names of those files to make it more clear as to what files they are
and what they are used for.

style.scss was renamed to style-base.scss as a simple fix to a
postCss problem.

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
modified:   src/auro-sub-menu.js
renamed:    src/style-fixed.scss -> src/style-base-fixed.scss
renamed:    src/style.scss -> src/style-base.scss
renamed:    src/auro-menu-option-fixed.scss -> src/style-menu-option-fixed.scss
renamed:    src/auro-menu-option.scss -> src/style-menu-option.scss
renamed:    src/auro-sub-menu-fixed.scss -> src/style-sub-menu-fixed.scss
renamed:    src/auro-sub-menu.scss -> src/style-sub-menu.scss

blackfalcon added a commit that referenced this issue


          refactor(isHidden): remove attribute #52

42b5812

Changes to be committed:
modified:   demo/demo.md
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js

blackfalcon added a commit that referenced this issue


          refactor(listOfOptions): remove unnecessary slot name convention #52

8f2847c

Changes to be committed:
modified:   demo/demo.md
modified:   src/auro-menu.js
modified:   test/auro-menu.test.js

blackfalcon added a commit that referenced this issue


          refactor(style): simplify checkmark ui #52

4e406c7

Changes to be committed:
modified:   demo/demo.md
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
modified:   src/style-base.scss
modified:   src/style-menu-option.scss
modified:   src/style-sub-menu.scss

blackfalcon closed this as completed

blackfalcon added a commit that referenced this issue


          refactor(styles): address naming conventions to style files #52

5ad01a5

There are a lot of files in the ./src directory, this commit updates
the names of those files to make it more clear as to what files they are
and what they are used for.

style.scss was renamed to style-base.scss as a simple fix to a
postCss problem.

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
modified:   src/auro-sub-menu.js
renamed:    src/style-fixed.scss -> src/style-base-fixed.scss
renamed:    src/style.scss -> src/style-base.scss
renamed:    src/auro-menu-option-fixed.scss -> src/style-menu-option-fixed.scss
renamed:    src/auro-menu-option.scss -> src/style-menu-option.scss
renamed:    src/auro-sub-menu-fixed.scss -> src/style-sub-menu-fixed.scss
renamed:    src/auro-sub-menu.scss -> src/style-sub-menu.scss

blackfalcon added a commit that referenced this issue


          refactor(isHidden): remove attribute #52

ece1c34

Changes to be committed:
modified:   demo/demo.md
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js

blackfalcon added a commit that referenced this issue


          refactor(listOfOptions): remove unnecessary slot name convention #52

bc5b6a9

Changes to be committed:
modified:   demo/demo.md
modified:   src/auro-menu.js
modified:   test/auro-menu.test.js

blackfalcon added a commit that referenced this issue


          refactor(style): simplify checkmark ui #52

57961d4

Changes to be committed:
modified:   demo/demo.md
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
modified:   src/style-base.scss
modified:   src/style-menu-option.scss
modified:   src/style-sub-menu.scss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment