AURO-MIGRATION: Update dependencies to support latest node version(s) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: last change was breaking _on a patch version_ because of peer dependencies Summary: Our current build process relies on peer dependencies being present, but the peer dependency pipeline is causing far more issues than it's worth. Why not just make them regular dependencies? This is what this PR does :)
Reviewer's Guide by SourceryThis pull request updates the project's dependencies to support newer Node.js versions (20.x and 22.x) and aligns with the latest Auro Design System packages. It also updates CDN links in the README to reflect these changes. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Surge demo deployment failed! 😭 |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @DukeFerdinand - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you're updating a lot of dependencies - can you confirm these are the versions you want?
- Consider using ranges instead of exact versions for peer dependencies to avoid conflicts.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+99
to
+100
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/design-tokens@/dist/auro-classic/CSSCustomProperties.css" /> | ||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@aurodesignsystem/webcorestylesheets@/dist/bundled/essentials.css" /> |
There was a problem hiding this comment.
issue (bug_risk): Missing version numbers in URLs for design tokens and web core stylesheets.
The updated URLs for the design tokens and web core stylesheets are missing version numbers. This could lead to unexpected behavior if the latest versions introduce breaking changes. It might be worth considering pinning to specific versions or providing guidance on how to manage versioning.
rmenner
approved these changes
Feb 28, 2025
DukeFerdinand
deleted the
dhook/2025_02_27_move_peerdeps_to_dependencies
branch
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves AlaskaAirlines/auro-cli#37 by updating eslint config to latest version (uses node >=18 for LTS support).
Summary by Sourcery
Updates dependencies to support the latest Node versions (20.x and 22.x).
Enhancements: