Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auro-popover: Update component registration logic #82

Closed
sun-mota opened this issue Oct 22, 2024 · 0 comments · Fixed by #83
Closed

Auro-popover: Update component registration logic #82

sun-mota opened this issue Oct 22, 2024 · 0 comments · Fixed by #83
Assignees

Comments

@sun-mota
Copy link
Contributor

Please verify the version of auro-popover you have installed

No response

Please describe the bug

Default import of index.js should register the default custom element only.

import of the component class should not register the custom element at all.

Remove all registration of custom-${component name} from the JS and only register as part of ./demo/index.js

Reproducing the error

None

Expected behavior

No response

What browsers are you seeing the problem on?

No response

Additional context

No response

Exit criteria

No response

@sun-mota sun-mota added Type: Bug Bug or Bug fixes auro-popover not-reviewed Issue has not been reviewed by Auro team members labels Oct 22, 2024
@sun-mota sun-mota self-assigned this Oct 22, 2024
sun-mota added a commit that referenced this issue Oct 23, 2024
- Update dependency versions

- `AuroPopover.register` is to easily register the element without extra importing
- `import "@aurodesignsystem/auro-popover"` will still register this element to <auro-popover>
- `import { AuroPopover } from '../src/auro-popover` wont register this element until `AuroPopover.register` gets called

- Fixed the typo on Recommended Use and Version Control: `clement` -> `element`
@sun-mota sun-mota linked a pull request Oct 23, 2024 that will close this issue
6 tasks
@jason-capsule42 jason-capsule42 removed Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members labels Oct 23, 2024
sun-mota added a commit that referenced this issue Oct 23, 2024
- Update dependency versions

- `AuroPopover.register` is to easily register the element without extra importing
- `import "@aurodesignsystem/auro-popover"` will still register this element to <auro-popover>
- `import { AuroPopover } from '../src/auro-popover` wont register this element until `AuroPopover.register` gets called

- Fixed the typo on Recommended Use and Version Control: `clement` -> `element`
blackfalcon pushed a commit that referenced this issue Oct 23, 2024
# [4.1.0](v4.0.1...v4.1.0) (2024-10-23)

### Features

* **api:** add register static method [#82](#82) ([2ac3681](2ac3681))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants