Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #124

Closed
jordanjones243 opened this issue Mar 13, 2024 · 1 comment · Fixed by #132 or #133
Closed

Update color tokens for theming support #124

jordanjones243 opened this issue Mar 13, 2024 · 1 comment · Fixed by #132 or #133
Assignees

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 13, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Exit Criteria

All hardcoded values and tier 1 tokens (brand tokens), are removed and replaced by semanticly named tier 2 and 3 tokens

@jordanjones243 jordanjones243 added Type: Feature New Feature auro-radio not-reviewed Issue has not been reviewed by Auro team members labels Mar 13, 2024
@jordanjones243
Copy link
Contributor Author

  • Hardcoded
    • Transparent
    • Solid
  • Tier 1
    • Checked box-shadow: box-shadow: inset 0 0 0 var(--shadow-inset) var(--ds-color-base-white, $ds-color-base-white);
      • Disabled
        • Border and background color: var(--ds-color-brand-gray-200, $ds-color-brand-gray-200);
        • Box-shadow: inset 0 0 0 var(--shadow-inset) var(--ds-color-base-white, $ds-color-base-white);
    • Radio label pseudo element border color: var(--ds-color-brand-gray-200, $ds-color-brand-gray-200);

@jason-capsule42 jason-capsule42 linked a pull request May 31, 2024 that will close this issue
22 tasks
@jordanjones243 jordanjones243 linked a pull request Aug 16, 2024 that will close this issue
6 tasks
jordanjones243 added a commit that referenced this issue Sep 24, 2024
BREAKING CHANGE: trigger major release for theme support #124
@jordanjones243 jordanjones243 mentioned this issue Sep 24, 2024
6 tasks
jordanjones243 added a commit that referenced this issue Sep 24, 2024
BREAKING CHANGE: trigger major release for theme support #124
blackfalcon pushed a commit that referenced this issue Sep 24, 2024
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-24)

### Performance Improvements

* update dependencies ([1477e9b](1477e9b))

### BREAKING CHANGES

* trigger major release for theme support #124
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for theme support #124
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-24)

### Performance Improvements

* update dependencies ([1477e9b](1477e9b))

### BREAKING CHANGES

* trigger major release for theme support #124
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0](v3.0.0...v4.0.0) (2024-09-30)

### Bug Fixes

* update incorrect token name ([d2eb0af](d2eb0af))
* update path to component js files ([ea311a4](ea311a4))

### Features

* **theme:** add theme support ([df19f57](df19f57))

### Performance Improvements

* **deps:** update to latest dependencies ([d6070d1](d6070d1))
* **deps:** update to latest dependencies ([77d2480](77d2480))
* refactor custom component registration config ([a75d52c](a75d52c))
* update dependencies ([55bc672](55bc672))
* update dependencies and lint configs ([8f7bcfe](8f7bcfe))

### BREAKING CHANGES

* trigger major release for theme support #124
@jason-capsule42 jason-capsule42 removed Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team members labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants