Skip to content

Commit

Permalink
fix(casing): follow attribute camel case consistency #88
Browse files Browse the repository at this point in the history
  • Loading branch information
jordanjones243 committed Sep 13, 2022
1 parent 2da2ac2 commit 252778f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion demo/apiExamples.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The auro-select element is a wrapper for auro-dropdown and auro-menu to create a
|------------------|------------------|-----------|------------------------|--------------------------------------------------|
| [disabled](#disabled) | `disabled` | `Boolean` | | When attribute is present element shows disabled state. |
| [error](#error) | `error` | `Boolean` | | When attribute is present element shows error state. |
| [nocheckmark](#nocheckmark) | `nocheckmark` | `Boolean` | | When true, checkmark on selected option will no longer be present. |
| [noCheckmark](#noCheckmark) | `noCheckmark` | `Boolean` | | When true, checkmark on selected option will no longer be present. |
| [optionSelected](#optionSelected) | `optionSelected` | `Object` | "undefined" | Specifies the current selected menuOption. |
| [placeholder](#placeholder) | `placeholder` | `String` | "Please select option" | Define placeholder text to display before a value is manually selected. |
| [value](#value) | `value` | `String` | | Value selected for the component. |
Expand Down
2 changes: 1 addition & 1 deletion docs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ The auro-select element is a wrapper for auro-dropdown and auro-menu to create a
|------------------|------------------|-----------|------------------------|--------------------------------------------------|
| `disabled` | `disabled` | `Boolean` | | When attribute is present element shows disabled state. |
| `error` | `error` | `Boolean` | | When attribute is present element shows error state. |
| `nocheckmark` | `nocheckmark` | `Boolean` | | When true, checkmark on selected option will no longer be present. |
| `noCheckmark` | `noCheckmark` | `Boolean` | | When true, checkmark on selected option will no longer be present. |
| `optionSelected` | `optionSelected` | `Object` | "undefined" | Specifies the current selected menuOption. |
| `placeholder` | `placeholder` | `String` | "Please select option" | Define placeholder text to display before a value is manually selected. |
| `value` | `value` | `String` | | Value selected for the component. |
Expand Down
6 changes: 3 additions & 3 deletions src/auro-select.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import styleCssFixed from './style-fixed-css.js';
* @prop {String} value - Value selected for the component.
* @prop {Boolean} error - When attribute is present element shows error state.
* @prop {Boolean} disabled - When attribute is present element shows disabled state.
* @prop {Boolean} nocheckmark - When true, checkmark on selected option will no longer be present.
* @prop {Boolean} noCheckmark - When true, checkmark on selected option will no longer be present.
* @attr {Object} optionSelected - Specifies the current selected menuOption.
* @slot - Default slot for the menu content.
* @slot label - Defines the content of the label.
Expand Down Expand Up @@ -70,7 +70,7 @@ class AuroSelect extends LitElement {
type: Boolean,
reflect: true
},
nocheckmark: {
noCheckmark: {
type: Boolean,
reflect: true
},
Expand Down Expand Up @@ -273,7 +273,7 @@ class AuroSelect extends LitElement {
this.shadowRoot.querySelector('auro-dropdown').removeAttribute('error');
}

if (this.nocheckmark) {
if (this.noCheckmark) {
this.menu.setAttribute('nocheckmark', '');
}
}
Expand Down

0 comments on commit 252778f

Please sign in to comment.