Skip to content

Commit

Permalink
perf: refactor custom component registration config
Browse files Browse the repository at this point in the history
  • Loading branch information
jordanjones243 authored and jason-capsule42 committed Oct 4, 2024
1 parent 84da4ea commit 9bada60
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 20 deletions.
7 changes: 4 additions & 3 deletions demo/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,10 @@
</script>

<script type="module">
import { registerComponent } from '../index.js';

registerComponent('custom-select');
import { AuroSelect } from '../src/auro-select.js';
import * as RuntimeUtils from '@aurodesignsystem/auro-library/scripts/utils/runtimeUtils.mjs';

RuntimeUtils.default.prototype.registerComponent('custom-select', AuroSelect);
</script>

<script src="https://cdn.jsdelivr.net/npm/@aurodesignsystem/auro-accordion@latest/dist/auro-accordion__bundled.js" type="module"></script>
Expand Down
6 changes: 4 additions & 2 deletions demo/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -376,8 +376,10 @@ There are two important parts of every Auro component. The <a href="https://deve
To protect from versioning conflicts with other instances of the component being loaded, it is recommended to use our `registerComponent(name)` method and pass in a unique name.

```js
import './node_modules/@aurodesignsystem/auro-select';
registerComponent('custom-select');
import { AuroSelect } from './src/auro-select.js';
import * as RuntimeUtils from '@aurodesignsystem/auro-library/scripts/utils/runtimeUtils.mjs';

RuntimeUtils.default.prototype.registerComponent('custom-select', AuroSelect);
```

This will create a new custom element that you can use in your HTML that will function identically to the `<auro-select>` element.
Expand Down
6 changes: 4 additions & 2 deletions docs/partials/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,10 @@ There are two important parts of every Auro component. The <a href="https://deve
To protect from versioning conflicts with other instances of the component being loaded, it is recommended to use our `registerComponent(name)` method and pass in a unique name.

```js
import './node_modules/@aurodesignsystem/auro-select';
registerComponent('custom-select');
import { AuroSelect } from './src/auro-select.js';
import * as RuntimeUtils from '@aurodesignsystem/auro-library/scripts/utils/runtimeUtils.mjs';

RuntimeUtils.default.prototype.registerComponent('custom-select', AuroSelect);
```

This will create a new custom element that you can use in your HTML that will function identically to the `<auro-select>` element.
Expand Down
15 changes: 2 additions & 13 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,4 @@
import { AuroSelect } from './src/auro-select.js';
import * as RuntimeUtils from '@aurodesignsystem/auro-library/scripts/utils/runtimeUtils.mjs';

/**
* Register Custom Element.
* @param {Object} name - Name to use for custom element.
* @returns {void}
*/
const registerComponent = (name = 'custom-select') => {
// alias definition
if (!customElements.get(name)) {
customElements.define(name, class extends AuroSelect {});
}
};

export { registerComponent };
RuntimeUtils.default.prototype.registerComponent('custom-select', AuroSelect);

0 comments on commit 9bada60

Please sign in to comment.