Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing hover state #102

Closed
leeejune opened this issue Sep 11, 2022 · 0 comments · Fixed by #113
Closed

Missing hover state #102

leeejune opened this issue Sep 11, 2022 · 0 comments · Fixed by #113
Assignees
@jordanjones243
Labels
auro-select Type: Bug Bug or Bug fixes
Milestone
Flight bug bash

Comments

@leeejune
Copy link

Describe the bug

There is no hover state for select.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Select.
  2. Hover over Select.
  3. See that there is no background color change.

Expected behavior

The hover state color should be auro-color-ui-bkg-hover-on-light

Screenshots

Screen Shot 2022-09-11 at 1 58 32 AM
Screen Shot 2022-09-09 at 9 19 48 AM

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

This change happened because we changed dropdown to not have a hover state as default. See AlaskaAirlines/auro-dropdown#147 for more contenxt.
@leeejune leeejune added not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes auro-select labels Sep 11, 2022
@blackfalcon blackfalcon removed their assignment Sep 12, 2022
@braven112 braven112 removed the not-reviewed Issue has not been reviewed by Auro team members label Sep 21, 2022
@jordanjones243 jordanjones243 self-assigned this Sep 22, 2022
jordanjones243 added a commit that referenced this issue Sep 22, 2022
@jordanjones243
fix(hover): make background color change on hover #102
4a9a1d4
@jordanjones243 jordanjones243 mentioned this issue Sep 22, 2022
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Sep 22, 2022 that will close this issue
add hover background color change #113
Merged
6 tasks
jordanjones243 added a commit that referenced this issue Sep 22, 2022
@jordanjones243
fix(hover): make background color change on hover #102
7cd017d
blackfalcon pushed a commit that referenced this issue Sep 22, 2022
@semantic-release-bot
chore(release): 2.5.3 [skip ci]
b6c197f 
## [2.5.3](v2.5.2...v2.5.3) (2022-09-22)

### Bug Fixes

* **hover:** make background color change on hover [#102](#102) ([7cd017d](7cd017d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-select Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
Flight bug bash
Development

Successfully merging a pull request may close this issue.

add hover background color change AlaskaAirlines/auro-select
4 participants
@blackfalcon @braven112 @jordanjones243 @leeejune