-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "Please select option" text shows outside the select and is persistent on the screen while the select has focus #119
Comments
@jeremeevans this is odd behavior. See from the screenshot there is a DOM element that appears, but it not respecting the utility class applied to it. This DOM sticks around when the bib is closed, but then disappears once there is another click. @jason-capsule42 can you shed light on this? |
I should also note, this issue does not happen on the doc site. Firefox or Chrome. |
This is a valid bug. The div that appears in the DOM because in order to follow the HTML5 workflow for screenreaders on select elements, we needed to have the screenreader read the label. This was not happening, so we had to insert a method that created a div that forced the screenreader to read the placeholder text and have it disappear from the DOM after the As for the class that is supposed to hide this |
The conclusion is that the mechanism that we are using to hide the assistive text is not available outside the scope of the shadow DOM, aka custom element. SpecUpdate the code to brute-force the hiding of the content directly on the HTML node versus relying on a CSS class Exit criteriaThis will be considered closed once the additional DOM element for assistive devices is no longer visible in any state or device. |
## [2.5.5](v2.5.4...v2.5.5) (2022-10-31) ### Bug Fixes * **label:** visibily hide label created for screenreaders [#119](#119) ([97cc680](97cc680))
The "Please select option" text shows outside the select and is persistent on the screen while the select has focus
If a select is focused, the "Please select option" text shows up (in this repro case) below the select. If you click on the select to close the selection menu, but retain focus on the select, the "Please select option" text remains on the screen.
To Reproduce
I created a minimal reproduction repository, in Vue...
Expected behavior
The "Please select option" text should now show anywhere other than in the select when an option is not selected.
Screenshots
Desktop (please complete the following information):
Additional context
Found by Karthi, not sure which broswer/OS she was using...
The text was updated successfully, but these errors were encountered: