Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected/Filled state not using primary color text #150

Closed
erikalanghauser opened this issue Feb 2, 2023 · 1 comment · Fixed by #151
Closed

Selected/Filled state not using primary color text #150

erikalanghauser opened this issue Feb 2, 2023 · 1 comment · Fixed by #151
Assignees
Labels
auro-select Type: Bug Bug or Bug fixes

Comments

@erikalanghauser
Copy link
Member

Describe the bug

The auro-select now shows the selected item in secondary (gray) text rather than the primary (black) text that it is designed to have. This causes inconsistencies when multiple types of input components sit next to each other (auro- input, dropdown, datepicker all use primary text for filled states.

To Reproduce

Steps to reproduce the behavior:

You can view on the auro doc site on 2.8.1.
image

Our flight search test env is on 2.8.0 and has the issue too.
image

Expected behavior

Should match design specs and use -primary-on-light.

Screenshots

See above.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

@erikalanghauser erikalanghauser added auro-select not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Feb 2, 2023
@leeejune
Copy link

leeejune commented Feb 14, 2023

Due to complexities in engineering, the placeholder and label text will always be text-secondary and the text color of value will always be text-primary.

The original design was to have the placeholder text-primary at all times.

@jason-capsule42 jason-capsule42 linked a pull request Feb 15, 2023 that will close this issue
6 tasks
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Feb 15, 2023
blackfalcon pushed a commit that referenced this issue Feb 15, 2023
## [2.8.2](v2.8.1...v2.8.2) (2023-02-15)

### Bug Fixes

* **placeholder:** add gray color for placeholder text [#150](#150) ([f1e83c1](f1e83c1))
* **placeholder:** placeholder text is now the right color [#150](#150) ([054cf56](054cf56))

### Performance Improvements

* **deps:** update dependencies to latest versions ([61fba46](61fba46))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-select Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants